Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update issue and PR templates #3113

Merged
merged 6 commits into from
Jan 11, 2023
Merged

chore: update issue and PR templates #3113

merged 6 commits into from
Jan 11, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Jan 11, 2023

PR Checklist

  • Brief description of changes
  • Links to any relevant issues
  • Required status checks are passing
  • User cases if changes impact the user's experience
  • @mention a maintainer to request a review

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #3113 (47724ef) into master (fe57c00) will decrease coverage by 0.73%.
The diff coverage is 2.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3113      +/-   ##
==========================================
- Coverage   12.68%   11.95%   -0.74%     
==========================================
  Files         306      306              
  Lines        8233     8435     +202     
  Branches     1593     1678      +85     
==========================================
- Hits         1044     1008      -36     
- Misses       5797     5941     +144     
- Partials     1392     1486      +94     
Impacted Files Coverage Δ
...latform/core/src/DICOMSR/SCOORD3D/parseSCOORD3D.js 2.66% <0.00%> (-0.73%) ⬇️
.../core/src/DICOMSR/SCOORD3D/utils/addMeasurement.js 5.40% <ø> (ø)
...re/src/DICOMSR/SCOORD3D/utils/getRenderableData.js 1.72% <0.00%> (-0.07%) ⬇️
...orm/core/src/DICOMSR/parseDicomStructuredReport.js 7.50% <0.00%> (-1.60%) ⬇️
platform/core/src/classes/HotkeysManager.js 76.66% <0.00%> (ø)
platform/core/src/classes/StudyLoadingListener.js 1.03% <0.00%> (+0.01%) ⬆️
...latform/core/src/classes/metadata/StudyMetadata.js 1.25% <0.00%> (-0.04%) ⬇️
.../core/src/measurements/tools/dicomSRDisplayTool.js 50.00% <0.00%> (ø)
...udies/services/wado/getReferencedSeriesSequence.js 7.69% <0.00%> (-0.65%) ⬇️
.../src/studies/services/wado/studyInstanceHelpers.js 1.56% <0.00%> (-0.48%) ⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9e4c9...47724ef. Read the comment docs.

@cypress
Copy link

cypress bot commented Jan 11, 2023



Test summary

76 0 0 0


Run details

Project Viewers
Status Passed
Commit 47724ef
Started Jan 11, 2023 9:44 PM
Ended Jan 11, 2023 9:50 PM
Duration 05:45 💡
OS Linux Debian - 10.6
Browser Chrome 86

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@sedghi sedghi requested review from jbocce and wayfarer3130 January 11, 2023 20:52
@sedghi sedghi changed the title chore: update issue templates chore: update issue and PR templates Jan 11, 2023
@sedghi sedghi merged commit cb9aa6a into master Jan 11, 2023
justvamp pushed a commit to MDWio/ohif-viewer that referenced this pull request Mar 2, 2023
* fix: OHIF#2964 Reword message for segmentation error loading due to orientation tolerance (OHIF#3017)

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* Re IDC OHIF#3067: Show eye-icon when segment label name is long (OHIF#3073)

* fix: OHIF#2964 Reword message for segmentation error loading due to orientation tolerance

* fix: Show eye-icon when segment name is long

* update python version

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* Re IDC OHIF#3047: update variable name for frame index (OHIF#3085)

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]
 - @ohif/[email protected]

* Re IDC OHIF#3088: Fix seg toggle visibility logic (OHIF#3101)

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* chore: update issue and PR templates (OHIF#3113)

* chore: update issue templates

* add template to PRs

* update for pr titles

* update

* update

* update description

* Re IDC OHIF#3077: Seg series thumbnail selection (OHIF#3078)

* fix: OHIF#3077 update seg tolerance popup and update seg thumbnail warning

* jump to first segment item image

* Shows warning message only once on onChange

* chore(release): publish [skip ci]

 - @ohif/[email protected]
 - @ohif/[email protected]

* fix crashing of large files

* remove fix

* remove unused import

---------

Co-authored-by: Gitanjali <[email protected]>
Co-authored-by: ohif-bot <[email protected]>
Co-authored-by: Alireza <[email protected]>
@sedghi sedghi deleted the feat/change-labels branch January 22, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants