fix(PT measurement units): Use the modality unit that arrives from cornerstone3d instead of calculating the modality unit (again) here. #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnerstone3d instead of calculating the modality unit (again) here. Added the 'petSeriesModule' to the MetadataProvider. This commit addresses OHIF issue 3439.
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3533 +/- ##
==========================================
- Coverage 42.81% 42.75% -0.06%
==========================================
Files 82 82
Lines 1448 1450 +2
Branches 338 338
==========================================
Hits 620 620
- Misses 665 667 +2
Partials 163 163
Continue to review full report in Codecov by Sentry.
|
sedghi
approved these changes
Jul 12, 2023
This was referenced Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Addresses OHIF issue #3439.
Changes & Results
Use the modality unit that arrives from cornerstone3d instead of calculating the modality unit (again) here.
Added the 'petSeriesModule' to the MetadataProvider.
SUV scaled PTs will continue to show SUV as the units for the various statistical measurements (i.e. mean, max standard deviation).
non-SUV scaled, but rescale slope and intercept scaled PTs will show the unit from the (0054,1001) (i.e. units) DICOM tag. If the units DICOM tag value is empty, 'unitless' will be displayed.
non-SUV AND non-rescale slope and intercept scaled PTS will show 'raw' as the unit.
This PR also requires the cornerstone PR 686 to get merged and OHIF dependency updated.
Testing
Ensure that issue #3439 is fully addressed. There are lots of notes in that issue that should be covered by this PR.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment