fix(PT measurement units): Non-SUV scaled, but pre-scaled PTs should show proper units #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-SUV scaled, but pre-scaled PTs show the units from the DICOM (0054,1001)/units tag.
✅ Deploy Preview for cornerstone-3d-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6 tasks
sedghi
reviewed
Jul 12, 2023
sedghi
reviewed
Jul 12, 2023
- introduced ModalityUnitOptions to pass around isSuvScale and isPreScaled - refactored getModalityUnit function for readability
sedghi
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The various ROI measurements (i.e. rectangle, ellipse, circle, etc.) on non-SUV scaled PTs were showing no units at all. Instead, the units should come from DICOM (0054,1001)/units tag.
SUV scaled PTs should continue to show 'SUV' as the units.
Changes & Results
Non-SUV scaled, but pre-scaled PTs show the units from the DICOM (0054,1001)/units tag.
SUV scaled PTs show SUV units.
The modality unit displayed as part of the measurement is now also added to the cached stats and fired with the ANNOTATION_ADDED event.
Testing
Add an ROI measurement to a PT and depending on its scaling, the appropriate unit should display for the statistics units.
Checklist
PR
semantic-release format and guidelines.
Code
My code has been well-documented (function documentation, inline comments,
etc.)
I have run the
yarn build:update-apito update the API documentation, and havecommitted the changes to this PR. (Read more here https://www.cornerstonejs.org/docs/contribute/update-api)
Public Documentation Updates
additions or removals.
Tested Environment