Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Playwright tests for tmtv #4331

Merged
merged 11 commits into from
Aug 16, 2024
Merged

Test: Playwright tests for tmtv #4331

merged 11 commits into from
Aug 16, 2024

Conversation

dxlin
Copy link
Contributor

@dxlin dxlin commented Aug 7, 2024

Context

Added playwright tests for:

  1. Basic TMTV Loading
  2. SUV re-calculates upon data reload
    -> Updating SUV parameters (time/injected dose) doesn't change the SUV[Bug] #3805
  3. Modality is PROPCNT when not calculable
    -> Units displayed as RAW in TMTV mode rather than PROPCNTS[Bug] #3760
  4. TMTV CT/PT alignment
    -> TMTV Coronal PET Viewport Instance Sometimes Incorrect [Bug]  #4035

Please feel free to make suggestions/removals/pick and choose useful bits.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 63cca7e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66beac601ccc5d0009e97f9e
😎 Deploy Preview https://deploy-preview-4331--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 7, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 63cca7e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66beac605c95ca000855522c

@sedghi sedghi requested a review from IbrahimCSAE August 8, 2024 15:35
@IbrahimCSAE
Copy link
Collaborator

I will review this once i get the chance, looks great though, might need to make some small adjustments to make it work in the CI.

@IbrahimCSAE IbrahimCSAE merged commit b2c0faf into OHIF:master Aug 16, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants