Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add rule to check for tcp_mss - v3 #1461

Closed
wants to merge 1 commit into from
Closed

tests: add rule to check for tcp_mss - v3 #1461

wants to merge 1 commit into from

Conversation

0xEniola
Copy link
Contributor

@0xEniola 0xEniola commented Nov 11, 2023 •
edited
Loading

Test for rule for tcp-mss keyword.

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6355

Suricata PR: OISF/suricata#9776

@0xEniola
tests: add rule to check for tcp_mss
aae198a 
Related to
Issue: #6355
@jufajardini jufajardini added the outreachy Contributions made by Outreachy applicants label Nov 13, 2023
jufajardini
jufajardini requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the feedback, output is looking good, imho.

Only one minor addition requested, from my end.

tests/rules/tcp-mss/test.yaml
Comment on lines +14 to +15
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.value: 50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have the check for the operand here, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! We should.

I did not remember to modify that after the conclusion on how to handle them.

@0xEniola 0xEniola closed this Nov 13, 2023
@jufajardini jufajardini changed the title tests: add rule to check for tcp_mss tests: add rule to check for tcp_mss - v3 Nov 13, 2023
@jufajardini jufajardini mentioned this pull request Nov 13, 2023
Closed
@0xEniola 0xEniola deleted the sv-task-6355-v3 branch January 31, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jufajardini jufajardini jufajardini requested changes

Assignees
No one assigned
Labels
outreachy Contributions made by Outreachy applicants
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xEniola @jufajardini