Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add rule to check for tcp_mss - v3 #1461

Closed
wants to merge 1 commit into from
Closed

tests: add rule to check for tcp_mss - v3 #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/rules/tcp-mss/test.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:50; sid:1;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:>123; sid:2;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:<536; sid:3;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:123-456; sid:4;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:>=439; sid:5;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:<=70; sid:6;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:!1000; sid:7;)
alert tcp any any -> any any (msg:"Testing mss"; tcp.mss:!=953; sid:8;)
72 changes: 72 additions & 0 deletions tests/rules/tcp-mss/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
requires:
min-version: 7.0.0
pcap: false

args:
- --engine-analysis

checks:
- filter:
filename: rules.json
count: 1
match:
id: 1
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.value: 50
Comment on lines +14 to +15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have the check for the operand here, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! We should.

I did not remember to modify that after the conclusion on how to handle them.

- filter:
filename: rules.json
count: 1
match:
id: 2
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.operand: "greater than"
lists.packet.matches[0].tcp_mss.value: 123
- filter:
filename: rules.json
count: 1
match:
id: 3
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.operand: "less than"
lists.packet.matches[0].tcp_mss.value: 536
- filter:
filename: rules.json
count: 1
match:
id: 4
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.operand: "range"
lists.packet.matches[0].tcp_mss.min: 123
lists.packet.matches[0].tcp_mss.max: 456
- filter:
filename: rules.json
count: 1
match:
id: 5
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.operand: "greater than or equal to"
lists.packet.matches[0].tcp_mss.value: 439
- filter:
filename: rules.json
count: 1
match:
id: 6
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.operand: "less than or equal to"
lists.packet.matches[0].tcp_mss.value: 70
- filter:
filename: rules.json
count: 1
match:
id: 7
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.operand: "not equal to"
lists.packet.matches[0].tcp_mss.value: 1000
- filter:
filename: rules.json
count: 1
match:
id: 8
lists.packet.matches[0].name: "tcp.mss"
lists.packet.matches[0].tcp_mss.operand: "not equal to"
lists.packet.matches[0].tcp_mss.value: 953
Loading