Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect-flowbits: add details for flowbits v6 #10006

Closed

Conversation

hadiqaalamdar
Copy link
Contributor

@hadiqaalamdar hadiqaalamdar commented Dec 7, 2023

Task #6309

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6309
Previous PR: #9971

Describe changes:

  • added the recommended changes from the last PR.

SV_BRANCH=OISF/suricata-verify#1526

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #10006 (163e4ce) into master (2fe2d82) will increase coverage by 0.06%.
Report is 161 commits behind head on master.
The diff coverage is 51.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10006      +/-   ##
==========================================
+ Coverage   82.39%   82.46%   +0.06%     
==========================================
  Files         968      970       +2     
  Lines      274337   271390    -2947     
==========================================
- Hits       226047   223791    -2256     
+ Misses      48290    47599     -691     
Flag Coverage Δ
fuzzcorpus 64.55% <0.00%> (-0.14%) ⬇️
suricata-verify 61.30% <51.42%> (+0.38%) ⬆️
unittests 62.87% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hadiqaalamdar
Copy link
Contributor Author

accidentally made two commits on this PR. Will be creating a new one shortly.

@hadiqaalamdar hadiqaalamdar deleted the detect-flowbits-6309-v6 branch December 7, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant