detect: add ldap operation keywords - v3 #12435
Open
+542
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldap.request.operation matches on Lightweight Directory Access Protocol request operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
ldap.responses.operation matches on Lightweight Directory Access Protocol response operations It is an unsigned 8-bit integer Doesn't support prefiltering Ticket: OISF#7453
ldap.responses.count matches on the number of LDAP responses It is an unsigned 32-bit integer Doesn't support prefiltering Ticket: OISF#7453
AkakiAlice
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
AkakiAlice
commented
Jan 20, 2025
| let tx = cast_pointer!(tx, LdapTransaction); | ||
| let ctx = cast_pointer!(ctx, DetectUintData<u8>); | ||
| if let Some(request) = &tx.request { | ||
| let option = request.protocol_op.to_u8(); |
There was a problem hiding this comment.
I went back to to_u8 because responses.protocol_op as u8 was giving the error:
an as expression can be used to convert enum types to numeric types only if the enum type is unit-only or field-less
This was referenced Jan 20, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12435 +/- ##
==========================================
+ Coverage 80.62% 80.63% +0.01%
==========================================
Files 920 921 +1
Lines 258697 258921 +224
==========================================
+ Hits 208566 208793 +227
+ Misses 50131 50128 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #7453
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7453
Description:
ldap.request.operation,ldap.responses.operationandldap.responses.countkeywords.Changes:
SV_BRANCH=OISF/suricata-verify#2243
Previous PR= #12343