Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add tls.cert_chain_len docs #9569

Closed

Conversation

jmtaylor90
Copy link
Contributor

@jmtaylor90 jmtaylor90 commented Oct 5, 2023

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

https://redmine.openinfosecfoundation.org/issues/6386

Describe changes:

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Sorry, something went wrong.

@jmtaylor90
Copy link
Contributor Author

The code work was done under https://redmine.openinfosecfoundation.org/issues/5191 / 682e2a0 it looks like the documentation was missed. So this is the associated doc work. Do we need a new redmine for this?

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #9569 (9db1c3f) into master (9157070) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9569      +/-   ##
==========================================
- Coverage   82.20%   82.19%   -0.01%     
==========================================
  Files         968      968              
  Lines      274275   274275              
==========================================
- Hits       225461   225449      -12     
- Misses      48814    48826      +12     
Flag Coverage Δ
fuzzcorpus 64.05% <ø> (+<0.01%) ⬆️
suricata-verify 60.92% <ø> (-0.03%) ⬇️
unittests 62.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@inashivb
Copy link
Member

inashivb commented Oct 6, 2023

The code work was done under https://redmine.openinfosecfoundation.org/issues/5191 / 682e2a0 it looks like the documentation was missed. So this is the associated doc work. Do we need a new redmine for this?

Looking at other Documentation tickets, I'd say yes. Preferably as a subtask of https://redmine.openinfosecfoundation.org/issues/5182

@jmtaylor90
Copy link
Contributor Author

The code work was done under https://redmine.openinfosecfoundation.org/issues/5191 / 682e2a0 it looks like the documentation was missed. So this is the associated doc work. Do we need a new redmine for this?

Looking at other Documentation tickets, I'd say yes. Preferably as a subtask of https://redmine.openinfosecfoundation.org/issues/5182

Thanks! It appears I don't have the redmine permissions to add a subtask to that ticket so I created the new ticket and added it as a related issue to 5182.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes look good, thanks for catching this :)

Considering now we have a ticket for it, would be good to have it on the commit message :P

@jmtaylor90
Copy link
Contributor Author

continued in #9597

@jmtaylor90 jmtaylor90 closed this Oct 11, 2023
@jmtaylor90 jmtaylor90 deleted the doc-add-tls-cert-chain-len-v1 branch October 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants