Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add tls.cert_chain_len docs v2 #9597

Closed

Conversation

jmtaylor90
Copy link
Contributor

Ticket: #6386

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

https://redmine.openinfosecfoundation.org/issues/6386

Describe changes:

  • Added ticket number to commit

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

Ticket: OISF#6386

Signed-off-by: jason taylor <[email protected]>
Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the ticket number to the commit!

Changes look good to me :)

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #9597 (4b0a824) into master (1a132f4) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9597      +/-   ##
==========================================
+ Coverage   82.28%   82.33%   +0.04%     
==========================================
  Files         968      968              
  Lines      274275   274275              
==========================================
+ Hits       225700   225822     +122     
+ Misses      48575    48453     -122     
Flag Coverage Δ
fuzzcorpus 64.50% <ø> (+0.16%) ⬆️
suricata-verify 60.91% <ø> (-0.02%) ⬇️
unittests 62.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jmtaylor90
Copy link
Contributor Author

Thanks for adding the ticket number to the commit!

Changes look good to me :)

Great! One thing I thought of as I was submitting this, do we want suricata-verify tests for this keyword? I don't see any currently.

@jufajardini
Copy link
Contributor

Thanks for adding the ticket number to the commit!
Changes look good to me :)

Great! One thing I thought of as I was submitting this, do we want suricata-verify tests for this keyword? I don't see any currently.

That's definitely a yes from my end, as this adds coverage and examples.

@victorjulien
Copy link
Member

Merged in #9637, thanks!

@jmtaylor90 jmtaylor90 deleted the doc-add-tls-cert-chain-len-v2 branch October 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants