Revert header changes to previous state #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Harsh Pandey <[email protected]>
harsh3dev
approved these changes
Jan 6, 2025
arkid15r
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Looks good.
I noticed the cursor goes from pointer to arrow after I click on any header link.
@harsh3dev @kasya could you check on your side?
For me it stays as a pointer for the time I am hovering on the link. Screen.Recording.2025-01-06.234920.mp4 |
Thanks for checking. I'll create another issue for that if it persists. |
arkid15r
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting Header component changes to previous state (before PR #252 )