Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the logging logic with SLF4J #30

Closed
forgedhallpass opened this issue Oct 4, 2021 · 2 comments · Fixed by #33
Closed

Replace the logging logic with SLF4J #30

forgedhallpass opened this issue Oct 4, 2021 · 2 comments · Fixed by #33
Assignees
@Matthajus
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@forgedhallpass
Copy link
Member

Use SLF4J (Simple Logging Facade for Java) for logging instead of the custom logger.

Make sure to update the test application, and add an slf4j implementation (e.g. Logback or Log4j 2) as test scoped dependency with example configuration that encodes CRLF characters to prevent log forging.

https://cheatsheetseries.owasp.org/cheatsheets/Injection_Prevention_in_Java_Cheat_Sheet.html
@forgedhallpass forgedhallpass added enhancement New feature or request good first issue Good for newcomers labels Oct 4, 2021
@Matthajus
Copy link
Contributor

Could you assign the issue to me, please?

@forgedhallpass
Copy link
Member Author

@Matthajus sure, let me know if you need any help. Happy coding!

@Matthajus Matthajus mentioned this issue Oct 8, 2021
Closed
@forgedhallpass forgedhallpass linked a pull request Oct 12, 2021 that will close this issue
Replace the logging logic with SLF4J #30 #33
Merged
forgedhallpass pushed a commit that referenced this issue Oct 19, 2021
@Matthajus
Replace the logging logic with SLF4J #30 (#33)
b5fa6c8
forgedhallpass added a commit that referenced this issue Oct 19, 2021
@forgedhallpass
Revert "Replace the logging logic with SLF4J #30 (#33)"
e2f83ce 
This reverts commit b5fa6c8.
forgedhallpass added a commit that referenced this issue Oct 19, 2021
@forgedhallpass
Replace the logging logic with SLF4J #30
7fe655c 
* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matthajus Matthajus

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace the logging logic with SLF4J #30
2 participants
@forgedhallpass @Matthajus