-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the logging logic with SLF4J #30 #32
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code cleanup
#30 IE9+ fix for frames
#28 unload defect (small fix)
Eclipse configuration
Patch for custom domain Origin.
Fix default class name for configuration factory
…ng token Description: location is tokenized on '#'. If a fragment exists, it is re-added back to location. Tokenization returns at most 2 substrings. Only the first '#' found in location is the index for tokenization, e.g. /myPath#myFragment#blah becomes [0] /myPath [1] myFragment#blah. Any '#' in the URL prior to fragment should have been encoded as '%23'.
- tag.jsp was using tags with hyphens. - On the properties, there was a space after the value in injectIntoAttributes, causing it to not be reconised correctly
Ensuring streams are closed within finally
Token name is used as HTTP header field name. Header field name containing an underscore can cause HTTP proxies to drop the header.
Fixed improperly formatted max-age Cache-Control config
Remove underscore from token name
Fix: only display log message saying "[...] CsrfGuard analyzing request [...] "if it is a protected object indeed
Properly closing streams within finally block
tokenname and tokenvalue tags fixed
Resolve issue where redirect with a fragment is invalid after appendi…
Fix element misses happening due to form injection
based on configuration.
org.owasp.csrfguard.JavascriptServlet.UnprotectedExtensions
…ing_with_tag Check that CSRFGuard is enabled before injecting tokens with JSP Tags…
This reverts commit d5f322e
Minor reordering of `static` and `final` modifier orders
* fixing a typo in the documentation * syncing the test Owasp.CsrfGuard.properties file with the production one
… + minor code cleanup
…ation with an embedded Tomcat, so that it could be shared with testers in cases when they have problems with building the application locally. Skipped by default.
…r the response has been committed.
…has a non-default value and the requester did not send a referer header.
* assign counter values to sessions * discard requests that do not have an associated session
@Matthajus you are trying to merge the |
forgedhallpass
requested changes
Oct 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to merge the master
into release/3.1.0
Replaced by #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the logging logic with SLF4J #30