Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test cases related to Authorization Response, fixed bugs found in them, and refactored #12

Merged

Conversation

ryosuke-wakaba
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba commented Jul 1, 2024

Added test cases related to Authorization Response, fixed bugs found in them, and refactored

Bug fixes

  • Fixed a case where state was forgotten to be included in the SIOPv2 response
  • Fixed an incorrect way of extracting provision performance information when providing JwtVcJson

Specification changes

  • Abolished request object reception using jwks in client_metadata (since such behavior is not described in the SIOPv2/OID4VP specifications)

Added test cases

  • Changed the case previously implemented as a success case to testSIOPv2RequestWithSignedRequestObjectFailure in response to the above specification changes
  • Reorganized existing SIOPv2 code as testRespondIdTokenResponse
  • Added testRespondVpTokenResponseSdJwtVc
  • Added testRespondVpTokenResponseJwtVcJson

Refactoring

  • Changed the return value of the function that processes the Authorization Response from Either to Result
  • Extracted jwkThumbprint generation process and made it a common process
  • Changed the return value of the process that generated and returned presentation information for each OpenIdProvider format from Triple to a dedicated class
  • Moved the relevant processing content to the Presentation.kt file

@ryosuke-wakaba ryosuke-wakaba changed the title Chore/add test case for response Added test cases related to Authorization Response, fixed bugs found in them, and refactored Jul 2, 2024
Copy link
Member

@moratori moratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🎉

@moratori moratori merged commit b60b44e into OWND-Project:main Jul 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants