Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliant vci id1 #21

Merged
merged 7 commits into from
Jan 15, 2025
Merged

Conversation

moratori
Copy link
Member

@moratori moratori commented Jan 6, 2025

Note: This PR needs to be merged first.

To enable proper communication with our VCI server implementation, the VCI-related implementation has been modified to conform to ID1.
For details of the modifications, refer to slide 7 of the following presentation:
https://docs.google.com/presentation/d/1J7-KxWuJKexrvsh9p4gt3pCpF00wdeEioP0stP6DDLU/edit?usp=sharing

Note: The iOS version has already been updated.
OWND-Project/OWND-Wallet-iOS#17

@moratori moratori marked this pull request as draft January 6, 2025 09:21
@moratori moratori marked this pull request as ready for review January 14, 2025 09:57
@moratori moratori changed the title WIP Compliant vci id1 Compliant vci id1 Jan 14, 2025
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryosuke-wakaba ryosuke-wakaba merged commit be23731 into OWND-Project:main Jan 15, 2025
1 check passed
@moratori moratori deleted the compliant-vci-id1 branch January 15, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants