Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vp same device flow #7

Merged
merged 5 commits into from
May 31, 2024
Merged

Add vp same device flow #7

merged 5 commits into from
May 31, 2024

Conversation

moratori
Copy link
Member

@moratori moratori commented May 24, 2024 •
edited
Loading

PR Overview

Background and Purpose

  • Support for Same-Device flow and refactoring of functions related to it.

Items implemented

@moratori
Copy link
Member Author

Please refer to this:
OWND-Project/OWND-Wallet-iOS#8 (comment)

@moratori moratori self-assigned this May 31, 2024
@moratori moratori requested a review from ryosuke-wakaba May 31, 2024 02:02
@moratori
Since it is unclear how to send a response when the response mode is …
fa0c832 
…other than POST, we will not implement it for now.
ryosuke-wakaba
ryosuke-wakaba approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@ryosuke-wakaba ryosuke-wakaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryosuke-wakaba ryosuke-wakaba merged commit 92274e1 into OWND-Project:main May 31, 2024
1 check passed
@moratori moratori deleted the add-vp-same-device-flow branch January 15, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryosuke-wakaba ryosuke-wakaba ryosuke-wakaba approved these changes

Assignees

@moratori moratori

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moratori @ryosuke-wakaba