-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy-loading of ghost objects only via properties access (no method overrides) #192
Conversation
Suggestion to clean up initialization: http://3v4l.org/JsRZ7 |
I should take a look into your solution ) I like such a non-standard feature. Probably it can help me to solve very old issue goaop/framework#54 |
@lisachenko it has the advantage of simplifying scope resolution by a lot, leaving it up to codegen and reducing runtime overhead to a minimum. |
@Ocramius yeah, runtime performance should be good, will try this POC later after SymfonyCon ) |
regarding http://3v4l.org/JsRZ7 either |
@staabm yes, there is a typo |
c0269cd
to
e05021d
Compare
… public methods that need implementation
…hods are involved
…nd avoid overriding any other existing method
…appen in the static constructor, for consistency
…enerator\Constructor`, as it is unused in a lazy loading ghost
…f the object, therefore doesn't trigger lazy-loading
…yGenerator\PrivatePropertiesMap`
…ctedProperties()`
…` skips protected methods
…retrieves also properties with the same and from different classes
…ies()` basic test
…ies()` with inheritance and property collisions
This one is ready for review. Also throw in nitpicking if there is anything to nitpick on. |
…hod being defined
$publicProperties, | ||
$protectedProperties, | ||
$privateProperties | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all this Magic*
with the same parameters, looks like duplication xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I'll consider converting it to a GhostObjectContext
or such
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred to #207
Documentation deferred to #208 |
POC of lazy-loading of ghost objects implemented only via properties existence
Basically a PoC implementation of #159.
Works with minimal code changes, but fatals have to be handled correctly.