Add handler to check ownership of repo or org #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mktcode
suggested changes
Mar 25, 2021
endpoints/check-ownership.js
Outdated
| const ownerType = nodeType == "Repository" ? response.data.node.owner.__typename : null | ||
|
|
||
| if (nodeType == "Repository" && ownerType == "User") { | ||
| const result = response.data.node.owner.id == githubUserId ? "true" : "false" |
There was a problem hiding this comment.
I think this should be an actual boolean. Makes it more easy on the contract side as well.
endpoints/check-ownership.js
Outdated
| if (response.data.node.__typename != "User") { | ||
| callback(500, Requester.errored(jobRunID, { checkOwnershipError: `Node (${githubUserId}) is not a User.` })) | ||
| } else { | ||
| const result = response.data.node.organization ? "true" : "false" |
jobs/check-ownership.json
Outdated
| ], | ||
| "tasks": [ | ||
| { "type": "check-ownership" }, | ||
| { "type": "ethbytes32" }, |
auto-merge was automatically disabled
March 26, 2021 15:03
Head branch was pushed to by a user without write access
|
@mktcode - fixed |
mktcode
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers: #10
Given a Github user ID and an ID for a Repository or Organization, the new handler checks whether the user is either:
The result is simply a "true" or "false" string for now, but we can obviously add more info in the response object if needed.
NOTE: We're only checking membership in the Organization for now as you need to be a member of an Organization to see what everyone's roles are. Hoping to fix this later.
Also, the version on the
@octobay/adapterslib was old and things were sort of breaking, so this was updated.