Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update database schema file path in drizzle config files #31

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

ZSmain
Copy link
Contributor

@ZSmain ZSmain commented Jul 7, 2024

Update the database schema file path in drizzle config files to match the new path by including the db folder in the path and this will solve the issue #30 (not finding the schema file) that will happen on migration.

Copy link

changeset-bot bot commented Jul 7, 2024

🦋 Changeset detected

Latest commit: ee81cf1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-sva Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@OllieJT
Copy link
Owner

OllieJT commented Jul 7, 2024

Thanks @ZSmain, you caught this just before me! #32

I really need to get CI tests up and running to avoid issues like this.

Copy link
Owner

@OllieJT OllieJT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a patch changeset? npx changeset

@OllieJT OllieJT changed the title Fix: update database schema file path in drizzle config files fix: update database schema file path in drizzle config files Jul 7, 2024
Copy link
Owner

@OllieJT OllieJT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you commited a package-lock.json -could you delete this?

I've made a note and will add package-lock.json and yarn.lock to the gitignore as we use a pnpm-lock.yaml.

@OllieJT OllieJT merged commit b55198c into OllieJT:main Jul 7, 2024
7 checks passed
Copy link
Contributor Author

@ZSmain ZSmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive my ignorance, first time contributing to a project, not familiar with this process, and thanks for the project.

@OllieJT
Copy link
Owner

OllieJT commented Jul 7, 2024

Forgive my ignorance, first time contributing to a project, not familiar with this process, and thanks for the project.

No worries at all, thanks for the contribution - means a lot :)

@OllieJT
Copy link
Owner

OllieJT commented Jul 7, 2024

This should be live on npm now as of version 0.1.12 @ZSmain

npm create sva@latest or npm create [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants