Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove undocumented experimental roughunder command #18

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Omikhleia
Copy link
Owner

Since Aug. 2022 (or earlier, can't remember and lazy to check), the framebox package has an experimental and undocumented \roughunder command using a sketchy line(s) for a replacement of the "underline" command. As noted in-code:

This would need to be re-implemented and checked after multiline effects (e.g. multiline links and underline) are possibly added to the typesetter.

Such "liners" spanning multiple lines are making it in SILE develop branch for 0.15 and likewise in silex.sile, which would allow to better implement this...
But the whole topic is moved to Omikhleia/resilient.sile#75 and Omikhleia/resilient.sile#76

--> Here we remove the undocumented command.

@Omikhleia Omikhleia added this to the 3.0 milestone Mar 5, 2024
@Omikhleia Omikhleia self-assigned this Mar 5, 2024
@Omikhleia Omikhleia merged commit 71b9e89 into main Mar 5, 2024
1 check passed
@Omikhleia Omikhleia deleted the refactor-remove-roughunder branch March 5, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant