Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-line effects #10

Merged
merged 10 commits into from
Feb 2, 2024
Merged

Multi-line effects #10

merged 10 commits into from
Feb 2, 2024

Conversation

Omikhleia
Copy link
Owner

@Omikhleia Omikhleia commented Jan 29, 2024 •
edited
Loading

A new approach derived from sile-typesetter/sile#1334

  • Cleaner API
  • More robust re-boxing logic in standard mode (= paragraphing)
    • Proper migrating content propagation (= footnotes)
    • Correct handling of discretionaries
      • Check for better approach
      • Check that the so-daid "better" approach didn't butcher rskip/lskip margins
  • Does not break in horizontal-restricted mode (= inside other horizontal box)
  • Use in packages
  • Branch on SILE core for regression testing
    • SILE manual fails. Investigate...
  • Extra robustness test: check it works as expected in a parbox too
  • Extra robustness test: check it works as expected in a boustrophedon

Caveat: It does further break the broken "pushback" logic (due to additional reboxing)

image

@Omikhleia Omikhleia self-assigned this Jan 29, 2024
@Omikhleia Omikhleia mentioned this pull request Jan 29, 2024
Closed
@Omikhleia Omikhleia force-pushed the feat-liner-support branch 3 times, most recently from 4b2fa5d to c20e88d Compare January 30, 2024 14:11
@Omikhleia
refactor: Updgrade outputters to 0.15-develop
42f168f 
Cause some names changed when the PR was merged there...
So we just re-align with them.
This is not expected to change anything for users.
@Omikhleia Omikhleia force-pushed the feat-liner-support branch 3 times, most recently from 539e5b5 to 662f7d5 Compare January 30, 2024 18:37
@Omikhleia Omikhleia mentioned this pull request Jan 30, 2024
Merged
@Omikhleia
Copy link
Owner Author

As mentioned, links too can now span multiple line:

image

@Omikhleia Omikhleia added this to the 0.5.0 milestone Jan 30, 2024
@Omikhleia
Copy link
Owner Author

Parboxing test (we rely on computed line ratios for the minimized case, so it's a good extra case)

image

@Omikhleia
Copy link
Owner Author

Also enjoying line-spanning underlines in a boustrophedon ('cause why not).

image

@Omikhleia
Copy link
Owner Author

Omikhleia commented Jan 31, 2024 •
edited
Loading

Checking we didn't butcher the margins (lskip/rskip) in parbox and regular paragraph after more refactoring (sile-typesetter/sile#1980)

image

EDIT: I really mean the (document) lskip and rskip "margins" here. Don't bother the unrelated "margins" frame in the screenshot (from resilient's layout)

@Omikhleia
Copy link
Owner Author

Omikhleia commented Feb 2, 2024 •
edited
Loading

Extra tests with some of my stuff:

  • lefevre article: one link on a QR code
  • resilient manual (not the latest version but a copy used from previous sile-x regression testing)
    • ToC links
    • Lots of colors (with autodoc-resilient variant)
  • markdown and djot manual (latest v1.5)
    • underline and strikethrough
    • one link on last page was long, overflowing the page frame - it should now be wrapped and still work.

@Omikhleia Omikhleia merged commit 5515c3c into main Feb 2, 2024
2 checks passed
@Omikhleia Omikhleia deleted the feat-liner-support branch February 2, 2024 18:57
This was referenced Feb 3, 2024
Closed
Closed
@Omikhleia Omikhleia mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Omikhleia Omikhleia

Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@Omikhleia