-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
styling paradigm v2 #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omikhleia
force-pushed
the
new-styling-paradigm
branch
4 times, most recently
from
February 19, 2023 20:30
a5e2e4e
to
c149ff4
Compare
Omikhleia
force-pushed
the
new-styling-paradigm
branch
2 times, most recently
from
February 27, 2023 19:31
f9db1ba
to
1973d09
Compare
Closed
Omikhleia
force-pushed
the
new-styling-paradigm
branch
from
March 1, 2023 02:25
19dec80
to
8d0eb2d
Compare
Easier maintenance, I'm losing my mind in the current file.
This size=+1 or size=-0.5 etc. idea was plain wrong in the first place. We need em-relative sizes for the more general case.
And refactor some doc chapters in separate folders, because I am getting lost. More structure, cleaner maintenance!
Includes the docs update, as there was no obvious way to split it and keep it working independently.
Breaking in the sense that it impacts how previous documents appeared by default (esp. due to shaper.spaceenlargementfactor) but the SILE defaults are utterly incorrect.
Too many information that most users do not need, it's a bit distracting and not worth the point yet.
Ah. Found at last, tricky problem when some paragraph styles were applied and the footnotes from them had weird indents!
- Common code extracted to resilient.utils - Some SILE hacks extracted to resilient.hacks
See lua-libraries/README.tinyyaml for reasons to vendor it and rename its source file.
Omikhleia
force-pushed
the
new-styling-paradigm
branch
from
March 12, 2023 00:54
223ec0b
to
878b451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12