Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong section number level in odd page header #47

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: wrong section number level in odd page header #47

merged 1 commit into from
May 18, 2023

Conversation

Omikhleia
Copy link
Owner

@Omikhleia Omikhleia commented May 18, 2023 •
edited
Loading

#46

Regression introduced in 2.0 when switching to the new style paradigm in #13: The section counter level is no longer used in formatting the counter, so we may get the current subsection instead!

EDIT: Clearly overlooked in #13 when conditional style-dependent formatting was added:
image

@Omikhleia Omikhleia self-assigned this May 18, 2023
@Omikhleia Omikhleia added the bug Something isn't working label May 18, 2023
@Omikhleia Omikhleia added this to the 2.1 milestone May 18, 2023
@Omikhleia Omikhleia merged commit 82f39c5 into main May 18, 2023
@Omikhleia Omikhleia deleted the fix-wrong-section-header branch May 18, 2023 10:12
Omikhleia added a commit that referenced this pull request Jun 22, 2023
@Omikhleia
fix: chapter title in running header should honor its numberstyle
f978d6c 
Closes #46
More precisely the second part of it (the first was fixed in #47).
This is slightly breaking (the header numberstyle was ignored on
chapters, but this was an oversight). Users might have to remove
it from their style file if they do no want it.
@Omikhleia Omikhleia mentioned this pull request Jun 22, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Omikhleia Omikhleia

Labels
bug Something isn't working
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Omikhleia