Upgrade dependencies #1237
Upgrade dependencies #1237
Conversation
| @@ -8,7 +8,7 @@ omnisharp-roslyn | |||
|
|
|||
| OmniSharp-Roslyn is a .NET development platform based on [Roslyn](https://github.com/dotnet/roslyn) workspaces. It provides project dependencies and language syntax to various IDE and plugins. | |||
|
|
|||
| OmniSharp-Roslyn is built with the [.NET Core SDK](https://dot.net/) on Windows and [Mono](http://www.mono-project.com/) on OSX/Linux. It targets the __net46__ target framework. OmniSharp requires __mono__ (>=5.2.0) if it is run on a platform other than Windows. | |||
| OmniSharp-Roslyn is built with the [.NET Core SDK](https://dot.net/) on Windows and [Mono](http://www.mono-project.com/) on OSX/Linux. It targets the __net461__ target framework. OmniSharp requires __mono__ (>=5.2.0) if it is run on a platform other than Windows. | |||
There was a problem hiding this comment.
Are some of the new dependencies netstandard only (>1.3), or what was the reason for targeting net461?
There was a problem hiding this comment.
This is to allow for netstandard2.0 loading and support. In addition https://github.com/OmniSharp/csharp-language-server-protocol is now netstandard2.0 (which is what caused me to start this separately)
| <PackageReference Update="Microsoft.AspNetCore.Hosting" Version="1.1.0" /> | ||
| <PackageReference Update="Microsoft.AspNetCore.Http.Features" Version="1.1.0" /> | ||
| <PackageReference Update="Microsoft.AspNetCore.Server.Kestrel" Version="1.1.0" /> | ||
| <PackageReference Update="McMaster.Extensions.CommandLineUtils" Version="2.2.4" /> |
There was a problem hiding this comment.
nice. got caught by surprise with this one the other day when upgrading another project - could not find the new version, only to discover it is not supported by MS anymore and this fork version should be used instead 😀
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net46</TargetFramework> | |||
| <TargetFramework>net461</TargetFramework> | |||
| <PlatformTarget>AnyCPU</PlatformTarget> | |||
There was a problem hiding this comment.
we could have all the libs as netstandard2.0 and just keep the entry projects net461
There was a problem hiding this comment.
be careful with this. There are known issues with netstandard2.0. I'd recommend sticking with net461 if there isn't a reason to switch.
There was a problem hiding this comment.
technically there is no real reason - other than maybe when we publish Nuget packages there might be easier to consume as netstandard2.0. That said I think the only reason anyone would consume OmniSharp packages would be to build things for OmniSharp so it wouldn't matter anyway
| logger.LogTrace(0, ex, message, args); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Cool! Are these now in the forked CommandLine package?
There was a problem hiding this comment.
they are finally part of Microsoft.Extensions.Logging, we can now use them since we moved from 1.1.0 to 2.1.1 aspnet/Logging#392
|
@DustinCampbell I pushed the change you mentioned into this branch to unblock this, as I'd really like to see this in - I think this should be good to merge now, cc: @david-driscoll |
|
@filipw thanks I started on this the other day then git distracted by a |
😭
|
🎉👍 |
NOTE: These changes are required for the latest LSP library.