-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies #1237
Upgrade dependencies #1237
Changes from all commits
99b54cf
b240da1
193d144
c0b9131
5cd6898
7ad9361
3aa2c1f
58ca2b2
db0c9b7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,57 +2,57 @@ | |
<Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
|
||
<PropertyGroup> | ||
<MSBuildPackageVersion>15.6.82</MSBuildPackageVersion> | ||
<NuGetPackageVersion>4.3.0</NuGetPackageVersion> | ||
<RoslynPackageVersion>2.8.0</RoslynPackageVersion> | ||
<MSBuildPackageVersion>15.7.179</MSBuildPackageVersion> | ||
<NuGetPackageVersion>4.7.0</NuGetPackageVersion> | ||
<RoslynPackageVersion>2.8.2</RoslynPackageVersion> | ||
<XunitPackageVersion>2.3.1</XunitPackageVersion> | ||
</PropertyGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Update="Cake.Scripting.Transport" Version="0.2.0" /> | ||
<PackageReference Update="Cake.Scripting.Transport" Version="0.3.0" /> | ||
|
||
<PackageReference Update="Dotnet.Script.DependencyModel" Version="0.6.1" /> | ||
<PackageReference Update="Dotnet.Script.DependencyModel.NuGet" Version="0.6.2" /> | ||
|
||
<PackageReference Update="Microsoft.AspNetCore.Diagnostics" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.AspNetCore.Hosting" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.AspNetCore.Http.Features" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.AspNetCore.Server.Kestrel" Version="1.1.0" /> | ||
<PackageReference Update="McMaster.Extensions.CommandLineUtils" Version="2.2.4" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nice. got caught by surprise with this one the other day when upgrading another project - could not find the new version, only to discover it is not supported by MS anymore and this fork version should be used instead 😀 |
||
|
||
<PackageReference Update="Microsoft.AspNetCore.Diagnostics" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.AspNetCore.Hosting" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.AspNetCore.Http.Features" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.AspNetCore.Server.Kestrel" Version="2.1.1" /> | ||
|
||
<PackageReference Update="Microsoft.Build" Version="$(MSBuildPackageVersion)" /> | ||
<PackageReference Update="Microsoft.Build.Framework" Version="$(MSBuildPackageVersion)" /> | ||
<PackageReference Update="Microsoft.Build.Tasks.Core" Version="$(MSBuildPackageVersion)" /> | ||
<PackageReference Update="Microsoft.Build.Utilities.Core" Version="$(MSBuildPackageVersion)" /> | ||
|
||
<PackageReference Update="Microsoft.CodeAnalysis.Common" Version="$(RoslynPackageVersion)" /> | ||
<PackageReference Update="Microsoft.CodeAnalysis.CSharp" Version="$(RoslynPackageVersion)" /> | ||
<PackageReference Update="Microsoft.CodeAnalysis.CSharp.Features" Version="$(RoslynPackageVersion)" /> | ||
<PackageReference Update="Microsoft.CodeAnalysis.CSharp.Scripting" Version="$(RoslynPackageVersion)" /> | ||
<PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="$(RoslynPackageVersion)" /> | ||
<PackageReference Update="Microsoft.CodeAnalysis.Workspaces.Common" Version="$(RoslynPackageVersion)" /> | ||
|
||
<PackageReference Update="Microsoft.Extensions.Caching.Memory" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.CommandLineUtils" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.Binder" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.CommandLine" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.Json" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.DependencyInjection" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.DependencyModel" Version="2.0.0" /> | ||
<PackageReference Update="Microsoft.Extensions.FileProviders.Physical" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.FileSystemGlobbing" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Logging" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Logging.Console" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Options" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.Options.ConfigurationExtensions" Version="1.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.PlatformAbstractions" Version="1.1.0" /> | ||
|
||
<PackageReference Update="Microsoft.Extensions.Caching.Memory" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.Binder" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.CommandLine" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Configuration.Json" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.DependencyInjection" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.DependencyModel" Version="2.1.0" /> | ||
<PackageReference Update="Microsoft.Extensions.FileProviders.Physical" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.FileSystemGlobbing" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Logging" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Logging.Console" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Options" Version="2.1.1" /> | ||
<PackageReference Update="Microsoft.Extensions.Options.ConfigurationExtensions" Version="2.1.1" /> | ||
|
||
<PackageReference Update="Microsoft.NET.Test.Sdk" Version="15.7.2" /> | ||
<PackageReference Update="Microsoft.TestPlatform.TranslationLayer" Version="15.7.2" /> | ||
<PackageReference Update="Microsoft.VisualStudio.Setup.Configuration.Interop" Version="1.14.114" /> | ||
<PackageReference Update="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="15.0.12" /> | ||
|
||
<PackageReference Update="Newtonsoft.Json" Version="9.0.1" /> | ||
|
||
<PackageReference Update="Nuget.Packaging" Version="$(NuGetPackageVersion)" /> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"sdk": { | ||
"version": "2.1.300" | ||
"version": "2.1.301" | ||
} | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
|
||
<PropertyGroup> | ||
<TargetFramework>net46</TargetFramework> | ||
<TargetFramework>net461</TargetFramework> | ||
<PlatformTarget>AnyCPU</PlatformTarget> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could have all the libs as netstandard2.0 and just keep the entry projects net461 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 on this! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. be careful with this. There are known issues with netstandard2.0. I'd recommend sticking with net461 if there isn't a reason to switch. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. technically there is no real reason - other than maybe when we publish Nuget packages there might be easier to consume as |
||
<RootNamespace>OmniSharp</RootNamespace> | ||
</PropertyGroup> | ||
|
@@ -12,7 +12,6 @@ | |
<PackageReference Include="Microsoft.Extensions.FileProviders.Physical" /> | ||
<PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" /> | ||
<PackageReference Include="Microsoft.Extensions.Logging" /> | ||
<PackageReference Include="Microsoft.Extensions.PlatformAbstractions" /> | ||
<PackageReference Include="Newtonsoft.Json" /> | ||
<PackageReference Include="NuGet.Versioning" /> | ||
<PackageReference Include="System.Collections.Immutable" /> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are some of the new dependencies
netstandard
only (>1.3), or what was the reason for targetingnet461
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to allow for netstandard2.0 loading and support. In addition https://github.com/OmniSharp/csharp-language-server-protocol is now netstandard2.0 (which is what caused me to start this separately)