Solve issue #1113.

[LoneBoco]

Send cancellation token when the server shuts down so we terminate the process.

[rchande]

@david-driscoll Does this look right to you?

[bjorkstromm]

I’d say we should look at updating LSP libs to latest instead. @david-driscoll, this is fixed there, right?

[bjorkstromm]

That said, I might have some time updating that in the end of this week.

[LoneBoco]

I took a look at OmniSharp.Extensions.LanguageServer version 0.10.0. I couldn't get it to work correctly because there has been a ton of changes since the 0.8.0 version I use in my local repository, but this would still be a problem with the latest version.

The issue is here:

omnisharp-roslyn/src/OmniSharp.Stdio.Driver/Program.cs

Lines 35 to 43 in 0496b7e

	using (var host = new LanguageServerHost(
	Console.OpenStandardInput(),
	Console.OpenStandardOutput(),
	application,
	cancellation))
	{
	host.Start().Wait();
	cancellation.Token.WaitHandle.WaitOne();
	}

OmniSharp.exe waits on the cancellation token. The only things that trigger this cancellation token is closing the console or waiting for the host process to terminate. If the host process sends an Exit request, the server will shut down, but the cancellation token for OmniSharp.exe will never get triggered, so the .exe keeps running.

If you want to use version 0.10.0, you have to do something like:

_server.Exit.Subscribe(_cancellationTokenSource.Token);

I think that would work. I never tested it though as I couldn't get 0.10.0 to work.

[rchande]

@mholo65 @david-driscoll I haven't been following along with LSP very much so I'm going to leave it to you to handle this PR.

[bjorkstromm]

Yes, I think we should add this to PR #1387. @LoneBoco, would you mind targeting that branch instead (feature/update-lsp) Otherwise, I can look in to it and add it.

[bjorkstromm]

LGTM 👍
Tried it out locally, and /shutdown works now. It didn't work with v1.32.9 release.

@LoneBoco I rebased this and also added a note to changelog. Thank you for your contribution!

@rchande would you mind approving the changelog?

[filipw]

👍