Update LSP to 0.11.x #1387
Merged
Update LSP to 0.11.x #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as well as behave in a more deireable way (all diagnostics will be pushed as the server starts up, etc)
- This is due to bug in Bakery. See cake-build/bakery#111 for more information.
bjorkstromm
commented
Jan 21, 2019
| @@ -80,7 +80,7 @@ private void DebugAttach() | |||
| { | |||
| if (Debug) | |||
| { | |||
| Console.WriteLine($"Attach debugger to process {Process.GetCurrentProcess().Id} to continue..."); | |||
| //Console.WriteLine($"Attach debugger to process {Process.GetCurrentProcess().Id} to continue..."); | |||
There was a problem hiding this comment.
Oops.. This should not be here.
BTW, @david-driscoll, we need a way to get this working with LSP? Currently VSCode starts yelling at me when non-json-RPC formatted content arrives on STDOUT.
There was a problem hiding this comment.
I'd be fine with it commented for now... worst case we can always have someone uncomment it for debugging purposes, if they haven't figure out which pid they need.
|
I'll be getting back to this tomorrow, to figure out what is causing issues with ci. |
Closed
Merged
david-driscoll
approved these changes
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @david-driscoll
There were still some issues with the Cake script service and incremental changes. I've disabled it for now and will enable once it works.