[Java] Update dependencies to address vulnerabilities #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./bin/java-petstore-all.sh
|
https://circleci.com/gh/OpenAPITools/openapi-generator/3871#tests/containers/1 |
|
Related PR @ okhttp: square/okhttp#4363 |
./bin/java-petstore-all.sh
|
cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) |
wing328
reviewed
Dec 23, 2018
| } | ||
|
|
||
| @Override | ||
| public Request request() { | ||
| return request; | ||
| } | ||
|
|
||
| @Override | ||
| public Timeout timeout() { |
There was a problem hiding this comment.
@ackintosh looks like it's not indented properly (4 extra spaces)
|
Thanks for the review! Fixed the indent. |
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Update retrofit2 refs: https://nvd.nist.gov/vuln/detail/CVE-2018-1000850 https://nvd.nist.gov/vuln/detail/CVE-2018-1000844 * Update samples ./bin/java-petstore-all.sh * Implement okhttp3.Call#timeout refs square/okhttp#4363 * Update samples ./bin/java-petstore-all.sh * Update Play26CallFactory * Fix indent
aloisklink
added a commit
to aloisklink/openapi-generator
that referenced
this pull request
May 11, 2020
Running mvn integration-test failed in samples/client/petstore/java/retrofit2-play24 This merges pull requests OpenAPITools#1735 and OpenAPITools#5527 into retrofit2-play24. Also removes the jackson-databind-version field, since it should always be the same as jackson-version, and updates build.gradle/build.sbt on-behalf-of: @nqminds <[email protected]>
wing328
added a commit
that referenced
this pull request
Jun 16, 2020
…rror) (#6679) * Add jersey2-experimental to petstore build script on-behalf-of: @nqminds <[email protected]> * [java] Add <source> to javadoc in pom.mustache We add the following <source> tag to the <configuration> of maven-javadoc-plugin for most pom.mustache files that use it. This tells javadoc which version of java the compiler used. This fixes the following error when running Java 11: [ERROR] Exit code: 1 - javadoc: error - The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module Additionally, we also add maven-compiler-plugin to jersey2/pom.mustache to specify that the source code is Java 6/7/8. on-behalf-of: @nqminds <[email protected]> * [java-jersey2-java6] Update failing old tests Pull-request #4666 changed jersey generation, but didn't update the test samples Tests now succeed. on-behalf-of: @nqminds <[email protected]> * [java-retrofit2-play24] Fix integration-tests Running mvn integration-test failed in samples/client/petstore/java/retrofit2-play24 This merges pull requests #1735 and #5527 into retrofit2-play24. Also removes the jackson-databind-version field, since it should always be the same as jackson-version, and updates build.gradle/build.sbt on-behalf-of: @nqminds <[email protected]> Co-authored-by: Alois Klink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Updated Retrofit2 to address the vulnerabilities: