Whole operation timeouts #4363
Merged
Whole operation timeouts #4363
+321
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yschimke
reviewed
Nov 4, 2018
yschimke
reviewed
Nov 4, 2018
yschimke
reviewed
Nov 4, 2018
yschimke
reviewed
Nov 4, 2018
yschimke
approved these changes
Nov 4, 2018
Strictly-speaking this change is backwards-incompatible because it adds a new method to the Call interface. The method returns the call's timeout. The trickiest part of this is signaling the end of the call, which occurs after the last byte is consumed of the last follow up request, or when the call fails. Fortunately this is made easier by borrowing the sites used by EventListener, which already plots out where calls end. #2840
swankjesse
force-pushed
the
jwilson.1104.whole_operation_timeout
branch
from
780d381 to
5373160
Compare
|
Yeah. I’m particularly happy with how reusable AsyncTimeout is. |
4 tasks
ackintosh
added a commit
to ackintosh/openapi-generator-1
that referenced
this pull request
Dec 22, 2018
wing328
pushed a commit
to OpenAPITools/openapi-generator
that referenced
this pull request
Dec 23, 2018
* Update retrofit2 refs: https://nvd.nist.gov/vuln/detail/CVE-2018-1000850 https://nvd.nist.gov/vuln/detail/CVE-2018-1000844 * Update samples ./bin/java-petstore-all.sh * Implement okhttp3.Call#timeout refs square/okhttp#4363 * Update samples ./bin/java-petstore-all.sh * Update Play26CallFactory * Fix indent
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Update retrofit2 refs: https://nvd.nist.gov/vuln/detail/CVE-2018-1000850 https://nvd.nist.gov/vuln/detail/CVE-2018-1000844 * Update samples ./bin/java-petstore-all.sh * Implement okhttp3.Call#timeout refs square/okhttp#4363 * Update samples ./bin/java-petstore-all.sh * Update Play26CallFactory * Fix indent
therve
pushed a commit
to DataDog/datadog-api-client-java
that referenced
this pull request
Mar 23, 2021
* Update retrofit2 refs: https://nvd.nist.gov/vuln/detail/CVE-2018-1000850 https://nvd.nist.gov/vuln/detail/CVE-2018-1000844 * Update samples ./bin/java-petstore-all.sh * Implement okhttp3.Call#timeout refs square/okhttp#4363 * Update samples ./bin/java-petstore-all.sh * Update Play26CallFactory * Fix indent
api-clients-generation-pipeline bot
pushed a commit
to DataDog/datadog-api-client-java
that referenced
this pull request
Sep 8, 2021
* Update retrofit2 refs: https://nvd.nist.gov/vuln/detail/CVE-2018-1000850 https://nvd.nist.gov/vuln/detail/CVE-2018-1000844 * Update samples ./bin/java-petstore-all.sh * Implement okhttp3.Call#timeout refs square/okhttp#4363 * Update samples ./bin/java-petstore-all.sh * Update Play26CallFactory * Fix indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly-speaking this change is backwards-incompatible because it adds
a new method to the Call interface. The method returns the call's timeout.
The trickiest part of this is signaling the end of the call, which
occurs after the last byte is consumed of the last follow up request,
or when the call fails. Fortunately this is made easier by borrowing
the sites used by EventListener, which already plots out where calls
end.
#2840