refactor: style errors from productivity measurement PR #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2023
|
Looks great, from here @Mustaballer we have to figure out why it is failing despite passing flake8 and black locally. |
|
Once #477 is merged, and this PR is updated, the status checks should pass. Also I don't believe that this should trigger a version bump(from the 'fix' in the PR title). Could you rename the PR title to |
angelala3252
changed the title
… feat/productivity
|
Thank you @angelala3252 ! 🙏 |
R-ohit-B-isht
pushed a commit
to R-ohit-B-isht/OpenAdapt
that referenced
this pull request
Jun 21, 2024
) * check for long gaps in recording * display basic productivity data in html page similar to visualize * show images for each window change * show productivity info for each window * WIP find tasks/cycles of ActionEvents * WIP find tasks/cycles of ActionEvents * WIP implementing brent's algorithm * implemented brent's algorithm * add task duration info + style changes to display * comments * floyd's algorithm and basic implementation of counting errors * implement longest repeated non-overlapping substring algorithm * removed unused code * small bug fixes * no empty window titles * small fixes * add title * edge case * make longest repeated substring recursive * changed window/tab switching * add number of actions in a task * add comments * make sure no non-repeating tasks are found * fix off by 1 error with window event screenshots * remove unused functions, comments, and some refactoring * docstrings * black * Undo changing PLOT_PERFORMANCE * style changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring to fix style errors in productivity PR
Summary
Checklist