Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: validate functionality of status checks #477

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Conversation

Mustaballer
Copy link
Collaborator

@Mustaballer Mustaballer commented Aug 24, 2023

What kind of change does this PR introduce?

Adds reference to the specific branch that is being pushed to, so the lint tests in the run-ci github action are running on the specific branch and not the main as it was in #452

Summary

Fix #452

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?

Other information

@Mustaballer
Copy link
Collaborator Author

@abrichr This PR resolves the following issue by adding reference to the branch and repo itself in main.yml

Currently, these actions are initiated after each commit push, but they exclusively target the main branch, disregarding the specific branch that is being pushed to.

The status check fails currently, but this should still be merged, and it should then update the status checks to run lint tests on the actual branch itself.

@Mustaballer
Copy link
Collaborator Author

@abrichr Ready for Review!

@abrichr abrichr merged commit 1485ae4 into main Aug 25, 2023
@abrichr abrichr deleted the test-status-checks branch August 25, 2023 18:34
R-ohit-B-isht pushed a commit to R-ohit-B-isht/OpenAdapt that referenced this pull request Jun 21, 2024
* chore: validate functionality of status checks

* test removing install script testing

* try removing docstring form module to see if its picked up

* add reference to pull request

* add removed docstring back for app __init__ file

* add missing check out statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Status check for run_ci github action is not running, "Expected — Waiting for status to be reported"
2 participants