Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design issues with uavcan.metatransport #96

Closed
pavel-kirienko opened this issue Dec 4, 2020 · 0 comments · Fixed by #99
Closed

Design issues with uavcan.metatransport #96

pavel-kirienko opened this issue Dec 4, 2020 · 0 comments · Fixed by #99
Assignees
@pavel-kirienko
Labels
enhancement minor

Comments

@pavel-kirienko
Copy link
Member

  • The timestamp field is not related to the data model so it should be removed. Timestamped types may be added later shall the need arise.
  • The MAC address in uavcan.equipment.udp should be extended to 8 bytes to support the EUI-64 format.

(this issue is related to my ongoing experimentation with Yukon)
@pavel-kirienko pavel-kirienko self-assigned this Dec 4, 2020
pavel-kirienko added a commit that referenced this issue Jan 6, 2021
@pavel-kirienko
Address #96 for CAN transport
b9b57d0
pavel-kirienko added a commit that referenced this issue Jan 6, 2021
@pavel-kirienko
Address #96 for serial
9a9d664
pavel-kirienko added a commit that referenced this issue Jan 6, 2021
@pavel-kirienko
Address #96 for UDP by replacing it with uavcan.metatransport.ethernet
530bcb7
@pavel-kirienko pavel-kirienko mentioned this issue Jan 6, 2021
Merged
pavel-kirienko added a commit that referenced this issue Jan 8, 2021
@pavel-kirienko
Address design issues in uavcan.metatransport (#99)
f07d09b 
* Address #96 for CAN transport

* Address #96 for serial

* Address #96 for UDP by replacing it with uavcan.metatransport.ethernet

* Add explicit deprecation note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavel-kirienko pavel-kirienko

Labels
enhancement minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address design issues in uavcan.metatransport OpenCyphal/public_regulated_data_types
1 participant
@pavel-kirienko