Address design issues in uavcan.metatransport #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-kirienko
added a commit
to OpenCyphal/pycyphal
that referenced
this pull request
Jan 9, 2021
pavel-kirienko
added a commit
to OpenCyphal/pycyphal
that referenced
this pull request
Jan 26, 2021
* Refactor UDP capture to sync up with OpenCyphal/public_regulated_data_types#99 * Fix MyPy issues * Fix PyLint issues * Remove dead reference from the docs * Correct the timeout treatment in the HOT alien reassembler to match the recommendations given in the Spec * Correct tracing in UDP and serial * Implement tracing for CAN * Add CANTracer tests * Add full integration tests for CAN capture * Add spoofing test rigging for the LoopbackTransport * LoopbackTransport: handle closure properly when using the spoofer * Slightly alter the tracing API to better reflect the underlying processes * Update the changelog * Deprecate UDPTransport(anonymous=True) in favor of local_node_id=None. This makes the API more self-consistent and easier to use. * Optimize noxfile for simpler local usage * Correct typing errors * Fix PyLint warning * Add serial port spoofing support -- this is necessary for advancing Yukon * Fix doc styling * Add support for CAN spoofing * Update spoofing docs & test * Address MyPy issues * Appease PyLint * Fix exception handling in get_fixed_port_id() * Fix closure and error handling in the node publisher to avoid irrelevant log entries * Report the local node-ID explicitly from UDPTransport.__repr__ * Fix the logger test * README: make the AppVeyor badge reflect the status of master rather than the latest build * Reset the version number to v1.2.0 beta 1 * Correct the logger test * Correct version syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a low-priority issue but it is cheap to address now. It will also unblock my ongoing background work on Yukon. Fixes #96
uavcan.metatransport.udpwithuavcan.metatransport.ethernetto enable more accurate modeling of the underlying media.