[PATCH v6] api: tm: add queue specific statistics counters #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
odpbuild
changed the title
|
This probably needs to be harmonized with the statistics proposed in PR 1237. Maybe the statistics to be enabled should be configurable so that they do not need to be tracked when not needed. |
nithind1988
reviewed
Jun 29, 2021
odpbuild
changed the title
psavol
reviewed
Jul 6, 2021
|
|
||
| /** Number of packets discarded due to other reasons (e.g. aging) than | ||
| * errors. */ | ||
| uint64_t discards; |
There was a problem hiding this comment.
Discarded octets counter will be added.
odpbuild
changed the title
psavol
reviewed
Jul 9, 2021
include/odp/api/spec/traffic_mngr.h
Outdated
| * @param odp_tm Odp_tm is used to identify the TM system into which this | ||
| * odp_tm_node object is created. | ||
| * @param tm Handle of the TM system into which this odp_tm_node object is | ||
| * created. |
There was a problem hiding this comment.
Original text has copy-paste error from create call - this is lookup.
psavol
reviewed
Jul 9, 2021
include/odp/api/spec/traffic_mngr.h
Outdated
|
|
||
| /** Number of packets discarded due to other reasons (e.g. aging) than | ||
| * errors. */ | ||
| uint64_t discard_packets; |
There was a problem hiding this comment.
This could be simply "discards" as in other APIs. If other APIs add discard_octets later, we have the same logic in all APIs (discards + discard_octets)
psavol
reviewed
Jul 9, 2021
| uint64_t discard_packets; | ||
|
|
||
| /** Number of packets which transmission errors. */ | ||
| uint64_t errors; |
odpbuild
changed the title
psavol
approved these changes
Jul 9, 2021
Fix typos and style issues and make variable naming more consistent in the traffic manager API documentation. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Petri Savolainen <[email protected]> Reviewed-by: Nithin Dabilpuram <[email protected]>
Add traffic manager queue specific statistics counters (odp_tm_queue_stats_t) and matching capabilities (odp_tm_queue_stats_capability_t). Statistics counters can be read with odp_tm_queue_stats() function. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Petri Savolainen <[email protected]> Reviewed-by: Nithin Dabilpuram <[email protected]>
Add implementation for the new odp_tm_queue_stats() function. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Petri Savolainen <[email protected]>
Add validation test for the new TM queue statistics APIs. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Petri Savolainen <[email protected]>
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add traffic manager queue specific statistics counters
(odp_tm_queue_stats_t) and matching capabilities
(odp_tm_stats_capability_t). Statistics counters can be reset with
odp_tm_queue_stats_reset() function and read with odp_tm_queue_stats().
V2:
odp_tm_queue_stats_reset()V3:
odp_tm_stats_capability_t->odp_tm_queue_stats_capability_tV4:
odp_tm_queue_stats_t.discard_octetsandodp_tm_queue_stats_t.discard_packetsV5:
odp_tm_queue_stats_t.discard_packetstoodp_tm_queue_stats_t.discards