Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH v5] api: tm: add node stats capability and query API #1325

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nithind1988
Copy link
Contributor

api: tm: add node stats capability and query API

Add capability to advertise capability of nodes at a given level
to provide statistics.

Also add a new API to query for packet sent count in green, yellow
and red color and packet drop count stats, along with corresponding
octet count statistics. TM node stats query will return only platform
supported statistics.

Signed-off-by: Nithin Dabilpuram [email protected]

linux-gen: tm: add node stats API stub

Add node stats API stub.

Signed-off-by: Nithin Dabilpuram [email protected]

@odpbuild odpbuild changed the title api: tm: add node stats capability and query API [PATCH v1] api: tm: add node stats capability and query API Jun 29, 2021
Copy link
Collaborator

@MatiasElo MatiasElo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments to sync this PR with #1305.

include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v1] api: tm: add node stats capability and query API [PATCH v2] api: tm: add node stats capability and query API Jul 20, 2021
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v2] api: tm: add node stats capability and query API [PATCH v3] api: tm: add node stats capability and query API Jul 20, 2021
Copy link
Collaborator

@MatiasElo MatiasElo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for some minor style tweaks and missing copyright the API changes are looking OK to me.

include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Outdated Show resolved Hide resolved
include/odp/api/spec/traffic_mngr.h Show resolved Hide resolved
@odpbuild odpbuild changed the title [PATCH v3] api: tm: add node stats capability and query API [PATCH v4] api: tm: add node stats capability and query API Jul 23, 2021
Add node per level capability to provide statistics.
Also add a stats query API for getting supported node statistics.

Signed-off-by: Nithin Dabilpuram <[email protected]>
Add node stats API stub.

Signed-off-by: Nithin Dabilpuram <[email protected]>
Add node stats test case similar to queue stats testcase.

Signed-off-by: Nithin Dabilpuram <[email protected]>
@odpbuild odpbuild changed the title [PATCH v4] api: tm: add node stats capability and query API [PATCH v5] api: tm: add node stats capability and query API Jul 23, 2021
@MatiasElo
Copy link
Collaborator

Hi @nithind1988,

Are we still expecting changes to this PR or is it ready from your point of view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants