Cleanup: removed broken Mage_Core_Controller_Front_Router (#4356)

* Fix: Mage_Core_Controller_Front_Router::getUrl() * phpstan * removed method * Delete app/code/core/Mage/Core/Controller/Front/Router.php * baseline --------- Co-authored-by: Ng Kiat Siong <[email protected]>
OpenMage · Dec 9, 2024 · dfa021b · dfa021b
1 parent f24a6a8
commit dfa021b
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 114 deletions.
diff --git a/.phpstan.dist.baseline.neon b/.phpstan.dist.baseline.neon
@@ -2535,16 +2535,6 @@ parameters:
 			count: 1
 			path: app/code/core/Mage/Core/Controller/Front/Action.php
 
-		-
-			message: "#^Call to an undefined method Zend_Controller_Router_Interface\\:\\:addRoute\\(\\)\\.$#"
-			count: 1
-			path: app/code/core/Mage/Core/Controller/Front/Router.php
-
-		-
-			message: "#^Parameter \\#1 \\$type of static method Mage\\:\\:getBaseUrl\\(\\) expects string, array given\\.$#"
-			count: 1
-			path: app/code/core/Mage/Core/Controller/Front/Router.php
-
 		-
 			message: "#^Constructor of class Mage_Core_Controller_Varien_Action has an unused parameter \\$invokeArgs\\.$#"
 			count: 1

diff --git a/app/Mage.php b/app/Mage.php
@@ -444,7 +444,7 @@ public static function getStoreConfigFlag($path, $store = null)
     /**
      * Get base URL path by type
      *
-     * @param string $type
+     * @param Mage_Core_Model_Store::URL_TYPE_* $type
      * @param null|bool $secure
      * @return string
      */

diff --git a/app/code/core/Mage/Core/Controller/Front/Router.php b/app/code/core/Mage/Core/Controller/Front/Router.php
diff --git a/app/code/core/Mage/Core/Model/Store.php b/app/code/core/Mage/Core/Model/Store.php
@@ -572,7 +572,7 @@ public function getUrl($route = '', $params = [])
     /**
      * Retrieve base URL
      *
-     * @param string $type
+     * @param self::URL_TYPE_* $type
      * @param bool|null $secure
      * @return string
      */