Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: removed broken Mage_Core_Controller_Front_Router #4356

Merged

Conversation

sreichel
Copy link
Contributor

Description (*)

Fatal error: Uncaught Exception: Notice: Array to string conversion in /var/www/html/app/code/core/Mage/Core/Model/Store.php on line 580

Manual testing scenarios (*)

$config = new Mage_Core_Model_Config_Element('<?xml version="1.0" encoding="utf-8" ?><test-url />');
$router = new Mage_Core_Controller_Front_Router($config);
var_dump($router->getUrl());

@github-actions github-actions bot added Component: Core Relates to Mage_Core Mage.php Relates to app/Mage.php labels Nov 15, 2024
app/Mage.php Show resolved Hide resolved
@kiatng
Copy link
Contributor

kiatng commented Nov 18, 2024

Any idea where is this class Mage_Core_Controller_Front_Router reference in the core? I didn't find any, should it be marked @deprecated?

@sreichel
Copy link
Contributor Author

Seems not to be used. I thought abiut to mark it deprecated, but there is no replacement that offers same functionallity.

kiatng
kiatng previously approved these changes Nov 24, 2024
@sreichel sreichel requested a review from addison74 November 24, 2024 03:39
@sreichel sreichel marked this pull request as draft November 29, 2024 02:13
@sreichel
Copy link
Contributor Author

should it be marked @deprecated?

Better to remove it? It was a fatal error in any case ... not usable at all.

@kiatng
Copy link
Contributor

kiatng commented Nov 30, 2024

Yes, it's not functional, make sense to remove.

@sreichel sreichel changed the title Bugfix: Mage_Core_Controller_Front_Router::getUrl() Cleanup: removed broken Mage_Core_Controller_Front_Router::getUrl() Nov 30, 2024
@sreichel sreichel marked this pull request as ready for review November 30, 2024 19:46
@sreichel sreichel requested a review from kiatng November 30, 2024 19:46
@kiatng
Copy link
Contributor

kiatng commented Dec 2, 2024

I was thinking removing the entire file.

@sreichel sreichel changed the title Cleanup: removed broken Mage_Core_Controller_Front_Router::getUrl() Cleanup: removed broken Mage_Core_Controller_Front_Router Dec 4, 2024
kiatng
kiatng previously approved these changes Dec 4, 2024
@sreichel sreichel marked this pull request as draft December 4, 2024 21:00
@sreichel sreichel marked this pull request as ready for review December 7, 2024 12:59
@sreichel sreichel requested a review from kiatng December 7, 2024 12:59
@kiatng kiatng merged commit dfa021b into OpenMage:main Dec 9, 2024
19 checks passed
@sreichel sreichel deleted the fix-Mage_Core_Controller_Front_Router-geturl branch December 9, 2024 05:31
fballiano added a commit to MahoCommerce/maho that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Component: Core Relates to Mage_Core Mage.php Relates to app/Mage.php phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants