Add email link to set password. See issue #1205. #1283

kiatng · 2020-10-26T04:08:12Z

Description (*)

When a customer account is created in backed, the password should not be emailed in plaintext. This PR add a new email template, which is modifed from the welcome email, by adding a link to set password.

For existing account, the email template used is the same as the forgot-password email.

This PR does not change existing feature on emailing plaintext password from backend, but it'll show a warning:

Related Pull Requests

Fixed Issues (if relevant)

Fixes Customer cannot see password in email when it is set in backend #1205

Manual testing scenarios (*)

There are 2 scenarios:

Creating New Customer

In backend, create a new customer with an email address which you own.
When you receive the email, click on the link to set the password.
Login with the new password.

Existing Customer

In backend customer page, go to the customer you created above.
Click on Email Link to Set Password.
When you receive the email, click on the link to reset the password.
Login with the new password.

Questions or comments

The landing page of the link is customer/account/changeforgotten with page title RESET PASSWORD. See screenshot. Does it need to be changed?

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All automated tests passed successfully (all builds are green)

rjocoleman · 2021-02-09T06:29:35Z

app/locale/en_US/template/email/account_new_password_link.html

+            <p class="highlighted-text">
+                Use the following values when prompted to log in:<br/>
+                <strong>Email</strong>: {{var customer.email}}<br/>
+                <strong>Password</strong>: (the password you set)


isn't this line redundant/confusing? (considering that the main call to action in this email is to click a link and set a password, therefor they don't have one already set?)

rjocoleman · 2021-02-09T06:39:16Z

app/code/core/Mage/Adminhtml/Block/Customer/Edit/Renderer/Newpass.php

@@ -49,6 +49,7 @@ public function render(Varien_Data_Form_Element_Abstract $element)
        if ($element->getNote()) {
            $html .= '<p class="note"><span>' . $element->getNote() . '</span></p>';
        }
+        $html .= '<p id="email-passowrd-warning" style="display:none;" class="note"><span>' . Mage::helper('customer')->__('Warning: email cotains password in plaintext will be sent.') . '</span></p>';


this isn't true because ~~a link is sent instead of a password?~~ this email template sends (the password you set when creating your account) in place of the password.

IMO the automatic email for a manually set password should be removed (if the manual password set feature is retained).

There's also a couple of typos: cotains and email-passowrd-warning

Warning: an email containing the plaintext password will be sent.

IMO the automatic email for a manually set password should be removed (if the manual password set feature is retained).

Hmmm... but it's hard to know if a use case exists where it's necessary to send a plaintext password to customer.

Anyway, the objective of this PR is to provide the UI for the backend admin to email a link to set password, especially for customer accounts created in the backend. The automatic email is an existng feature that can be addressed separetely, I don't want to do too many things.

…enMage#2892)

* Better exceptions for file upload * PHPCS fixes * PHPCS fixes

Instead of checking the results of preg_match by counting the length of the string, simply check for the success value. This prevents PHP 8.1 deprecation warnings.

…e#1490) * New event so more validation classes can be added on the fly I ran into a situation where I needed more complex validation rules like min and max length for strings and min and max values for integers. Without this change, I cannot make it. * Added missing cast to array * resolve codestyle issue * change arrays append to ArrayObject->append() Co-authored-by: Daniel Fahlke <[email protected]>

…penMage#1490)" (OpenMage#2910) This reverts commit a22d834.

….0 (OpenMage#2912)

…OpenMage#2904)

…penMage#2586)

…nMage#1114 (OpenMage#2919)

… js/prototype/validation.js (OpenMage#2609)

kiatng · 2023-05-14T02:47:36Z

I tried to rebase by following this guide: https://gist.github.com/scottyhq/299e4d36018a2f13acfb2528a1553002. But it doesn't seem to work. Is there a guide I can use to rebase?

fballiano · 2023-05-14T09:04:53Z

I follow this guide from @colinmollenhour and it works perfectly: OpenMage/rfcs#10 (comment)

(I always use the "squash" part of the guide)

addison74 · 2023-05-14T09:16:53Z

I would close this PR and create a new one because the number of modified files appears to be +5000, being attached from other PRs. I can't test it because there are too many conflicts.

kiatng · 2023-05-15T05:34:15Z

See PR #3262

github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Customer Relates to Mage_Customer translations Relates to app/locale labels Oct 26, 2020

rjocoleman reviewed Feb 9, 2021

View reviewed changes

fballiano and others added 25 commits January 4, 2023 13:17

Removed info about Magento versions merging (OpenMage#2894)

31dbf46

Use getCouponCode method instead of _getData(), ref OpenMage#2825 (Op…

74bd26a

…enMage#2892)

Updated README.md (OpenMage#2897)

6d6df0c

PHPStan updated to 1.9.7, phpstan-magento1 to 1.0.5 (OpenMage#2896)

470591d

Better exceptions for file upload (OpenMage#2902)

6acbbec

* Better exceptions for file upload * PHPCS fixes * PHPCS fixes

Added default return string to getParam() (OpenMage#2893)

88646fa

Ensure count() is not called on a string (OpenMage#2888)

8b23674

Instead of checking the results of preg_match by counting the length of the string, simply check for the success value. This prevents PHP 8.1 deprecation warnings.

Cast return of getClass() to string (OpenMage#2905)

8a60871

Revert "New event so more validation classes can be added on the fly (O…

ccbe6b8

…penMage#1490)" (OpenMage#2910) This reverts commit a22d834.

Bump symplify/vendor-patches from 11.1.24 to 11.1.31.72 (OpenMage#2911)

00ae819

Bump phpstan/phpstan from 1.9.7 to 1.9.8 (OpenMage#2913)

485682b

Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0…

37fbac1

….0 (OpenMage#2912)

Ensure null value not passed to str_replace (OpenMage#2901)

390a79c

In Mage_Adminhtml switched some constants to Mage_Core_Model_Template (…

01cfff3

…OpenMage#2904)

Removed unused autoloaders in lib (OpenMage#2859)

2a51e75

[PHP 8.1] Fix passing null to non-nullable internal function params (O…

6acdeaa

…penMage#2586)

Fixed "searching for utf8 characters breaks product limiter", ref Ope…

f420b9c

…nMage#1114 (OpenMage#2919)

Removed scriptaculous/effects.js dependency in hideAdvice() method in…

af4555e

… js/prototype/validation.js (OpenMage#2609)

Better error handling when XML file cannot be parsed (OpenMage#2923)

8fdb7dd

WRD theme: removed border bottom from h1/h2

4a2ab67

Fixed getOpenMageMajorVersion() for v20 branch

f572765

Removed method setIsDownloader() which shouldn't exist in v20

324d40b

Fixed getAttributeRawValue return false if value is '0' (OpenMage#572)

40dce4c

Added info about OpenMage#572 to README (OpenMage#2926)

adb5f73

kiatng closed this May 15, 2023

addison74 mentioned this pull request Sep 11, 2023

Add email link to set password. See issue #1205. #3262

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add email link to set password. See issue #1205. #1283

Add email link to set password. See issue #1205. #1283

kiatng commented Oct 26, 2020

rjocoleman Feb 9, 2021 •

edited

Loading

rjocoleman Feb 9, 2021 •

edited

Loading

rjocoleman Feb 9, 2021 •

edited

Loading

kiatng Feb 10, 2021

kiatng commented May 14, 2023

fballiano commented May 14, 2023

addison74 commented May 14, 2023

kiatng commented May 15, 2023

Add email link to set password. See issue #1205. #1283

Add email link to set password. See issue #1205. #1283

Conversation

kiatng commented Oct 26, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Creating New Customer

Existing Customer

Questions or comments

Contribution checklist (*)

rjocoleman Feb 9, 2021 • edited Loading

Choose a reason for hiding this comment

rjocoleman Feb 9, 2021 • edited Loading

Choose a reason for hiding this comment

rjocoleman Feb 9, 2021 • edited Loading

Choose a reason for hiding this comment

kiatng Feb 10, 2021

Choose a reason for hiding this comment

kiatng commented May 14, 2023

fballiano commented May 14, 2023

addison74 commented May 14, 2023

kiatng commented May 15, 2023

rjocoleman Feb 9, 2021 •

edited

Loading

rjocoleman Feb 9, 2021 •

edited

Loading

rjocoleman Feb 9, 2021 •

edited

Loading