Fix typo in Observer.php #2899
Closed
Fix typo in Observer.php #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
occured -> occurred
|
Set to draft .... see OpenMage/rfcs#8 |
Sdfendor
approved these changes
Jan 5, 2023
|
Based on the feedback here OpenMage/rfcs#8, in such situations the change must be made only on the second column of the CSV translation file. As a programmer, I don't like to see spelling or expression errors in the source code or different values in a CSV row, but that's what the majority wants. @eltociear - please update you PR by changing only this file https://github.com/OpenMage/magento-lts/blob/4d1869e5985305a1aa8ca5b9627df7f13a0fd464/app/locale/en_US/Mage_Adminhtml.csv in line 107, column 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
occured -> occurred
Contribution checklist (*)