Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes typo in observer #2942

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Fixes typo in observer #2942

merged 1 commit into from
Jan 15, 2023

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Jan 15, 2023 •
edited
Loading

Description (*)

Related Pull Requests

  1. Closes Fix typo in Observer.php #2899

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the translations Relates to app/locale label Jan 15, 2023
@fballiano fballiano merged commit 6bbd2de into 1.9.4.x Jan 15, 2023
@fballiano fballiano deleted the fix/typo branch January 15, 2023 10:32
fballiano pushed a commit that referenced this pull request Jan 15, 2023
@sreichel @fballiano
Fixed translation for typo in app/code/core/Mage/Core/Model/Observer.…
f9faec2 
…php (#2942)
@fballiano
Copy link
Contributor

merged and cherrypicked to v20 with no conflict

@addison74
Copy link
Contributor

I will make a list at some point with all the phrases that are modified in this way. I think that so far there are around 8 such changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
translations Relates to app/locale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @addison74