Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to NotifyStock feed is shown only if enabled #3520

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Link to NotifyStock feed is shown only if enabled #3520

merged 2 commits into from
Sep 18, 2023

Conversation

fballiano
Copy link
Contributor

This link:
Screenshot 2023-09-17 alle 23 47 19

should appear only if the RSS is actually enabled.

This PR should fix this.

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Sep 17, 2023
kiatng
kiatng previously approved these changes Sep 18, 2023
addison74
addison74 previously approved these changes Sep 18, 2023
@fballiano fballiano dismissed stale reviews from addison74 and kiatng via 580fb67 September 18, 2023 08:08
@fballiano
Copy link
Contributor Author

thanks guys, I had to fix a phpcs error (which I wasn't expecting actually, and looks weird to me now, but anyway)

@fballiano
Copy link
Contributor Author

I'll merge it just to get rid of it since it was actually approved before the phpcs whitespace fix (which I don't like anyway but... it's phpcs...)

@fballiano fballiano merged commit 3a7de34 into OpenMage:main Sep 18, 2023
@fballiano fballiano changed the title Link to NotifyStock feed only if enabled Link to NotifyStock feed is shown only if enabled Sep 18, 2023
@boesbo
Copy link
Contributor

boesbo commented May 15, 2024

@fballiano The same problem occurs in the following files:

app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php
app/code/core/Mage/Adminhtml/Block/Review/Grid.php

@fballiano
Copy link
Contributor Author

@boesbo created #3997 to fix those too ;-)

@boesbo
Copy link
Contributor

boesbo commented May 15, 2024

@boesbo created #3997 to fix those too ;-)

You are great! I would have done it in the afternoon but you were very fast

@fballiano
Copy link
Contributor Author

ehheheh sorry :-)

if you can check that it works for you too and leave a review I can try to merge it quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants