Better config for admin RSS links #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Component: Adminhtml
addison74
approved these changes
Oct 4, 2024
kiatng
approved these changes
Oct 14, 2024
fballiano
reviewed
Oct 15, 2024
| ) { | ||
| $this->addRssList('rss/order/new', Mage::helper('sales')->__('New Order RSS')); | ||
| if (Mage::helper('sales')->isModuleOutputEnabled('Mage_Rss')) { | ||
| $filterString = $this->getParam($this->getVarNameFilter()); |
There was a problem hiding this comment.
this can be null and it triggers a null parameter warning in prepareFilterString
There was a problem hiding this comment.
@sreichel Can you fix:
[type] => 8192:E_DEPRECATED
[message] => base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated
[file] => app\code\core\Mage\Adminhtml\Helper\Data.php
[line] => 108
There was a problem hiding this comment.
Thanks. PR comming. How to reproduce?
There was a problem hiding this comment.
go to the sales->order backend page...
fballiano
reviewed
Oct 15, 2024
| $filter = Mage::helper('adminhtml')->prepareFilterString($filterString); | ||
| $storeId = array_key_exists('store_id', $filter) ? $filter['store_id'] : null; | ||
|
|
||
| if (Mage::helper('rss')->isRssAdminOrderNewEnabled($storeId)) { |
There was a problem hiding this comment.
if ($storeId && Mage::helper('rss')->isRssAdminOrderNewEnabled($storeId)) {
There was a problem hiding this comment.
$storeId is used one line later and default view (when i remember right?)
if (Mage::helper('rss')->isRssAdminOrderNewEnabled($storeId)) {
$slug = $storeId ? '/store/' . $storeId : '';
$this->addRssList('rss/order/new' . $slug, Mage::helper('sales')->__('New Order RSS'));
}
sreichel
added a commit
to sreichel/magento-lts
that referenced
this pull request
Oct 16, 2024
… string is deprecated - OpenMage#4243 (comment)
sreichel
added a commit
that referenced
this pull request
Oct 18, 2024
* PHP8: base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated - #4243 (comment) * refactor * refactor * refactor * refactor [skip ci] * Update app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php Co-authored-by: Ng Kiat Siong <[email protected]> --------- Co-authored-by: Ng Kiat Siong <[email protected]>
github-actions bot
pushed a commit
to mdsxbm/maho
that referenced
this pull request
Oct 19, 2024
* PHP8: base64_decode(): Passing null to parameter MahoCommerce#1 ($string) of type string is deprecated - OpenMage/magento-lts#4243 (comment) * refactor * refactor * refactor * refactor [skip ci] * Update app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php Co-authored-by: Ng Kiat Siong <[email protected]> --------- Co-authored-by: Ng Kiat Siong <[email protected]>
github-actions bot
pushed a commit
to justinbeaty/maho
that referenced
this pull request
Oct 19, 2024
* PHP8: base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated - OpenMage/magento-lts#4243 (comment) * refactor * refactor * refactor * refactor [skip ci] * Update app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php Co-authored-by: Ng Kiat Siong <[email protected]> --------- Co-authored-by: Ng Kiat Siong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Description here: #2760
Related Pull Requests