Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Avoid modifying the array when reading file URLs for browser downloads #3234

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Nov 25, 2024

Fixes issue #3232 caused by this array no longer being possible to modify in place.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.66%. Comparing base (4a5bf01) to head (dc6da53).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...pp/src/scripts/dataset/download/download-native.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3234   +/-   ##
=======================================
  Coverage   45.66%   45.66%           
=======================================
  Files         595      595           
  Lines       38013    38013           
  Branches     1167     1167           
=======================================
  Hits        17357    17357           
  Misses      20459    20459           
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 43a047e into master Nov 25, 2024
13 of 15 checks passed
@nellh nellh deleted the 3232-browser-download-fix branch November 25, 2024 22:11
Copy link

sentry-io bot commented Nov 26, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Failed to fetch /datasets/ds003871/versions/1.0.2 View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant