Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Avoid modifying the array when reading file URLs for browser downloads #3234

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
// Skip files which are already complete
if (fileHandle.size == file.size) continue
const writable = await fileHandle.createWritable()
const { body, status, statusText } = await fetch(file.urls.pop())
const { body, status, statusText } = await fetch(file.urls[0])

Check warning on line 85 in packages/openneuro-app/src/scripts/dataset/download/download-native.js

View check run for this annotation

Codecov / codecov/patch

packages/openneuro-app/src/scripts/dataset/download/download-native.js#L85

Added line #L85 was not covered by tests
let loaded = 0
const progress = new TransformStream({
transform(chunk, controller) {
Expand Down
Loading