Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive loading for schema validator output #3322

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Feb 5, 2025

This avoids loading the BIDS validator output for schema validator datasets, instead loading this once the validation drop down is clicked. For many datasets this avoids several megabytes of data transfer and potentially expensive API requests until this is actually needed.

A related bug fix is included to more accurately disable creating snapshots when the schema validator output contains errors or the draft has no author values provided.

See #3313

@nellh nellh requested a review from thinknoack February 5, 2025 23:04
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 54.40415% with 88 lines in your changes missing coverage. Please review.

Project coverage is 47.21%. Comparing base (769d876) to head (3729f05).

Files with missing lines Patch % Lines
...src/scripts/validation/validation-results-query.ts 56.81% 19 Missing ⚠️
...enneuro-server/src/graphql/resolvers/validation.ts 0.00% 19 Missing ⚠️
...-app/src/scripts/validation/validation-results.tsx 48.38% 16 Missing ⚠️
...nneuro-app/src/scripts/dataset/routes/snapshot.tsx 0.00% 13 Missing ⚠️
...penneuro-app/src/scripts/validation/validation.tsx 79.31% 12 Missing ⚠️
packages/openneuro-server/src/graphql/schema.ts 0.00% 5 Missing ⚠️
...enneuro-app/src/scripts/uploader/upload-issues.tsx 0.00% 2 Missing ⚠️
...nneuro-app/src/scripts/dataset/draft-container.tsx 0.00% 1 Missing ⚠️
...pp/src/scripts/dataset/routes/tab-routes-draft.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3322      +/-   ##
==========================================
- Coverage   47.72%   47.21%   -0.51%     
==========================================
  Files         590      591       +1     
  Lines       37666    37751      +85     
  Branches     1272     1243      -29     
==========================================
- Hits        17976    17826     -150     
- Misses      19503    19738     +235     
  Partials      187      187              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant