Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive loading for schema validator output #3322

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Progressive loading for schema validator output #3322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
88aa481
feat(server): Add warnings and error counts to schema validator resol…
nellh Feb 5, 2025
1ab46e0
fix(components): Only render AccordionTab children when visible
nellh Feb 5, 2025
66fcb38
fix(app): Update snapshot creation checks for schema validation
nellh Feb 5, 2025
aa191b3
feat(app): Add progressive loading for schema validator output
nellh Feb 5, 2025
ae9f94f
chore(app): Cleanup debugging in snapshotValidation resolver
nellh Feb 5, 2025
83a1f42
tests(app): Update tests for progressive validation
nellh Feb 5, 2025
3729f05
fix(app): Separate ValidationResults into loading and display components
nellh Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions packages/openneuro-app/src/scripts/datalad/dataset/dataset-query-fragments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,13 +135,8 @@ export const DATASET_ISSUES = gql`
${ISSUE_FIELDS}
}
validation {
codeMessages {
code
message
}
issues {
${VALIDATION_FIELDS}
}
errors
warnings
}
}
}
Expand All @@ -154,13 +149,8 @@ export const SNAPSHOT_ISSUES = gql`
${ISSUE_FIELDS}
}
validation {
codeMessages {
code
message
}
issues {
${VALIDATION_FIELDS}
}
errors
warnings
}
}
`
Expand Down
308 changes: 4 additions & 304 deletions ...penneuro-app/src/scripts/dataset/__tests__/__snapshots__/snapshot-container.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,124 +181,7 @@ exports[`SnapshotContainer component > renders successfully 1`] = `
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<div>
<span
class="message error fade-in"
>
We found
<strong>
1 Warning
</strong>
in your dataset. You are not required to fix warnings, but doing so will make your dataset more BIDS compliant.
</span>
</div>
<br />
<div
class="validation-messages on-accordion-wrapper"
>
<article
class="plain accordion fade-in upload-panel warning-wrap"
>
<div
class="accordion-title "
role="switch"
>
<span>
view 1 warning in 1 file
</span>
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<div
class=" on-accordion-wrapper"
>
<article
class="plain accordion validation-error fade-in"
>
<div
class="accordion-title "
role="switch"
>
<span
class="file-header"
>
<h4
class="em-header"
>
<strong
class="em-header "
>
Warning: 1
</strong>
<span
class="file-issue-count"
>
1 file
</span>
</h4>
Tabular file contains custom columns not described in a data dictionary
</span>
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<div
class="em-body"
>
<span
class="e-meta"
>
<span>
<label>
Location:
</label>
<p>
/participants.tsv
</p>
</span>
</span>
<span
class="e-meta"
>
<label>
Reason:
</label>
<p>
Tabular file contains custom columns not described in a data dictionary
</p>
</span>
<span
class="e-meta"
>
<label>
Evidence:
</label>
<p>
Columns: sex, age not defined, please define in: /participants.json
</p>
</span>
</div>
</div>
</div>
</article>
</div>
</div>
</div>
</article>
</div>
</div>
</div>
/>
</article>
</div>
</div>
Expand Down Expand Up @@ -670,174 +553,7 @@ OCI-1131441 (R. Poldrack, PI) in any publications.
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<ul
class="child-files"
>
<li
class="clearfix filetree-item filetree-file"
>
<span
aria-label=""
class=" on-icon "
role="img"
style="color: orange;"
>
<i
class="fas fa-file-alt"
/>
</span>
  CHANGES
<span
class="filetree-editfile"
/>
</li>
<li
class="clearfix filetree-item filetree-file"
>
<span
aria-label=""
class=" on-icon "
role="img"
style="color: deepskyblue;"
>
<i
class="fab fa-markdown"
/>
</span>
  README
<span
class="filetree-editfile"
/>
</li>
<li
class="clearfix filetree-item filetree-file"
>
<span
aria-label=""
class=" on-icon "
role="img"
style="color: limegreen;"
>
<i
class="fab fa-node-js"
/>
</span>
  T1w.json
<span
class="filetree-editfile"
/>
</li>
<li
class="clearfix filetree-item filetree-file"
>
<span
aria-label=""
class=" on-icon "
role="img"
style="color: limegreen;"
>
<i
class="fab fa-node-js"
/>
</span>
  dataset_description.json
<span
class="filetree-editfile"
/>
</li>
<li
class="clearfix filetree-item filetree-file"
>
<span
aria-label=""
class=" on-icon "
role="img"
style="color: lightgreen;"
>
<i
class="fas fa-file-excel"
/>
</span>
  participants.tsv
<span
class="filetree-editfile"
/>
</li>
<li
class="clearfix filetree-item filetree-dir"
>
<article
class="file-tree accordion "
>
<div
class="accordion-title "
role="switch"
>
<span
aria-label="sub-01"
class="file-icon on-icon icon-text "
role="img"
>
<i
class="fas fa-folder"
/>
sub-01
</span>
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<div>
Loading...
</div>
</div>
</div>
</article>
</li>
<li
class="clearfix filetree-item filetree-dir"
>
<article
class="file-tree accordion "
>
<div
class="accordion-title "
role="switch"
>
<span
aria-label="sub-02"
class="file-icon on-icon icon-text "
role="img"
>
<i
class="fas fa-folder"
/>
sub-02
</span>
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<div>
Loading...
</div>
</div>
</div>
</article>
</li>
</ul>
</div>
</div>
/>
</article>
</div>
</div>
Expand Down Expand Up @@ -1003,15 +719,7 @@ OCI-1131441 (R. Poldrack, PI) in any publications.
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<div>
Loading...
</div>
</div>
</div>
/>
</article>
</li>
<li
Expand All @@ -1037,15 +745,7 @@ OCI-1131441 (R. Poldrack, PI) in any publications.
</div>
<div
class="accordion-item collapsed "
>
<div
class="accordion-content"
>
<div>
Loading...
</div>
</div>
</div>
/>
</article>
</li>
</ul>
Expand Down
Loading
Loading