Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix selected track display #10394

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

theocrsb
Copy link
Contributor

@theocrsb theocrsb commented Jan 15, 2025

fix #10372
fix #10414

@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (13d0dd3) to head (6255f1f).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10394   +/-   ##
=======================================
  Coverage   81.89%   81.90%           
=======================================
  Files        1078     1079    +1     
  Lines      107178   107248   +70     
  Branches      724      729    +5     
=======================================
+ Hits        87771    87839   +68     
- Misses      19367    19369    +2     
  Partials       40       40           
Flag Coverage Δ
editoast 74.17% <ø> (-0.01%) ⬇️
front 89.46% <100.00%> (+0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch 7 times, most recently from 6ebdd08 to 91c86cb Compare January 16, 2025 17:14
@theocrsb theocrsb marked this pull request as ready for review January 16, 2025 17:20
@theocrsb theocrsb requested a review from a team as a code owner January 16, 2025 17:20
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch from 91c86cb to aa9a0a2 Compare January 17, 2025 08:25
@RomainValls
Copy link
Contributor

Nice fix ! It also closes #10299, there were duplicates :)

@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch from d408ed1 to b9316ab Compare January 17, 2025 11:18
@theocrsb theocrsb requested a review from SharglutDev January 20, 2025 10:46
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch 3 times, most recently from a5318cc to 27b9449 Compare January 21, 2025 06:09
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch 2 times, most recently from 731425f to b7e6857 Compare January 22, 2025 09:06
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch 2 times, most recently from e4fedab to ed9bb7e Compare January 23, 2025 15:46
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch from ed9bb7e to 607ad3c Compare January 31, 2025 08:43
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch 2 times, most recently from 7fa70d7 to ec7bbf9 Compare February 3, 2025 08:40
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job ! You can resolve the last comment yourself

@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch from ec7bbf9 to 4617ee6 Compare February 3, 2025 09:54
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

@theocrsb theocrsb requested a review from emersion February 4, 2025 08:37
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch 2 times, most recently from 091e06b to 09a31d3 Compare February 5, 2025 09:36
@theocrsb theocrsb enabled auto-merge February 5, 2025 09:41
@theocrsb theocrsb force-pushed the tce/front/bug-wrong-track-display branch from 09a31d3 to 6255f1f Compare February 5, 2025 14:46
@theocrsb theocrsb added this pull request to the merge queue Feb 5, 2025
Merged via the queue into dev with commit 8d4d91c Feb 5, 2025
27 checks passed
@theocrsb theocrsb deleted the tce/front/bug-wrong-track-display branch February 5, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intinerary marker not always defined Inconsistency between the selected track and the track displayed
6 participants