Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagating the "transient error" functionality to electrical profile sets #3168

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Feb 11, 2023

No description provided.

@Castavo Castavo requested a review from a team as a code owner February 11, 2023 23:06
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #3168 (4a78a86) into dev (32a3b75) will increase coverage by 0.03%.
Report is 4 commits behind head on dev.
The diff coverage is 78.87%.

@@             Coverage Diff              @@
##                dev    #3168      +/-   ##
============================================
+ Coverage     19.97%   20.00%   +0.03%     
- Complexity     2323     2325       +2     
============================================
  Files           869      869              
  Lines         88481    88518      +37     
  Branches       2283     2287       +4     
============================================
+ Hits          17677    17712      +35     
+ Misses        69543    69541       -2     
- Partials       1261     1265       +4     
Flag Coverage Δ
core 80.25% <78.87%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../fr/sncf/osrd/api/ElectricalProfileSetManager.java 80.00% <76.56%> (-4.45%) ⬇️
...a/fr/sncf/osrd/reporting/exceptions/ErrorType.java 100.00% <100.00%> (ø)
...a/fr/sncf/osrd/reporting/exceptions/OSRDError.java 29.82% <100.00%> (+7.30%) ⬆️

@multun
Copy link
Contributor

multun commented Feb 12, 2023

@Castavo there's a conflict, and the commit name is a little off; how about core: api: handle electrical profile transient download errors

@Castavo Castavo self-assigned this Apr 12, 2023
@Castavo Castavo force-pushed the bpt/transient-error-electrical-profiles branch 3 times, most recently from 92f813f to 58b625f Compare May 12, 2023 12:38
@multun multun force-pushed the bpt/transient-error-electrical-profiles branch from 58b625f to 00544ff Compare July 18, 2023 09:00
@multun multun requested review from a team, eckter and flomonster as code owners July 18, 2023 09:00
@multun
Copy link
Contributor

multun commented Jul 26, 2023

@Castavo I know it's been a while; I'd like to get this merged:

@multun multun removed request for a team, eckter and flomonster July 26, 2023 09:15
@Castavo Castavo added area:core Work on Core Service kind:feature-task Work related to a feature epic labels Jul 26, 2023
@Castavo Castavo force-pushed the bpt/transient-error-electrical-profiles branch from 00544ff to 4a78a86 Compare July 28, 2023 14:36
@Castavo Castavo requested a review from multun July 31, 2023 08:18
@multun multun added this pull request to the merge queue Jul 31, 2023
Merged via the queue into dev with commit dcb8071 Jul 31, 2023
@multun multun deleted the bpt/transient-error-electrical-profiles branch July 31, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service kind:feature-task Work related to a feature epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants