Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: avoid adding an invalid cache entry when using an unloaded infra #4496

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jul 4, 2023

Fixes a bug that would prevent infra loading when receiving a request before the infra has started loading.

We would put a default InfraCacheEntry (INITIALIZING) when missing from the cache, but the infra isn't actually being loaded.

@eckter eckter requested a review from a team as a code owner July 4, 2023 13:27
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (39c05f1) 27.70% compared to head (5952343) 27.70%.
Report is 1 commits behind head on dev.

Files Patch % Lines
...e/src/main/java/fr/sncf/osrd/api/InfraManager.java 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #4496      +/-   ##
============================================
- Coverage     27.70%   27.70%   -0.01%     
  Complexity     2165     2165              
============================================
  Files          1002     1002              
  Lines        126258   126257       -1     
  Branches       2580     2580              
============================================
- Hits          34979    34976       -3     
- Misses        89790    89791       +1     
- Partials       1489     1490       +1     
Flag Coverage Δ
core 78.58% <25.00%> (-0.01%) ⬇️
editoast 75.74% <ø> (-0.01%) ⬇️
front 8.35% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.42% <ø> (ø)
tests 81.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter force-pushed the ech/fix-core-cache-status branch 2 times, most recently from d8989d4 to 5b312f6 Compare July 7, 2023 09:10
@multun multun force-pushed the ech/fix-core-cache-status branch from 5b312f6 to 8d0f4d1 Compare July 18, 2023 09:00
@multun multun requested review from a team as code owners July 18, 2023 09:00
@multun multun enabled auto-merge July 26, 2023 08:18
@multun multun removed request for a team July 26, 2023 08:22
auto-merge was automatically disabled August 29, 2023 08:57

Merge queue setting changed

@Khoyo Khoyo force-pushed the ech/fix-core-cache-status branch from 8d0f4d1 to 5952343 Compare January 18, 2024 12:41
@Khoyo Khoyo enabled auto-merge January 18, 2024 12:43
@Khoyo Khoyo added this pull request to the merge queue Jan 18, 2024
Merged via the queue into dev with commit 21b851e Jan 18, 2024
21 checks passed
@Khoyo Khoyo deleted the ech/fix-core-cache-status branch January 18, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants