Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: migrations: add delete on cascade for dead sections #4681

Merged
merged 1 commit into from
Aug 7, 2023
Merged

api: migrations: add delete on cascade for dead sections #4681

merged 1 commit into from
Aug 7, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Jul 27, 2023

close: #4676

@Castavo Castavo marked this pull request as ready for review July 27, 2023 16:13
@Castavo Castavo requested a review from a team as a code owner July 27, 2023 16:13
@Castavo Castavo self-assigned this Jul 28, 2023
flomonster
flomonster approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Reviewed but not tested.

@Castavo Castavo force-pushed the bpt/fix/dead-section-cascade branch from 9183b69 to 024d556 Compare August 7, 2023 13:03
@Castavo Castavo enabled auto-merge August 7, 2023 13:03
@Castavo Castavo added this pull request to the merge queue Aug 7, 2023
Merged via the queue into dev with commit 948156c Aug 7, 2023
@Castavo Castavo deleted the bpt/fix/dead-section-cascade branch August 7, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesschrifi younesschrifi younesschrifi approved these changes

@flomonster flomonster flomonster approved these changes

@Tguisnet Tguisnet Awaiting requested review from Tguisnet

Assignees

@Castavo Castavo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't delete an infra with dead sections
3 participants
@Castavo @flomonster @younesschrifi